From: Linus Torvalds <torvalds@linux-foundation.org>
To: Davide Libenzi <davidel@xmailserver.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Arnd Bergmann <arnd@arndb.de>, Al Viro <viro@ftp.linux.org.uk>,
Michael Kerrisk <mtk.manpages@gmail.com>,
Christoph Hellwig <hch@infradead.org>
Subject: Re: [patch] F_GETPATH implementation
Date: Mon, 14 Apr 2008 15:48:51 -0700 (PDT) [thread overview]
Message-ID: <alpine.LFD.1.00.0804141545530.2879@woody.linux-foundation.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0804141227490.7954@alien.or.mcafeemobile.com>
On Mon, 14 Apr 2008, Davide Libenzi wrote:
> Index: linux-2.6.mod/include/asm-generic/fcntl.h
> ===================================================================
> --- linux-2.6.mod.orig/include/asm-generic/fcntl.h 2008-04-13 15:01:09.000000000 -0700
> +++ linux-2.6.mod/include/asm-generic/fcntl.h 2008-04-13 18:37:35.000000000 -0700
> @@ -73,6 +73,7 @@
> #define F_SETSIG 10 /* for sockets. */
> #define F_GETSIG 11 /* for sockets. */
> #endif
> +#define F_GETPATH 12
This won't work.
Different architectures have different F_xyzzy numbers, and 12 is already
used by various ones (it's F_SETOWN in asm-parisc/fcntl.h, for example).
I think you'd have to do it in terms of F_LINUX_SPECIFIC_BASE, like
F_NOTIFY is done, for example. That way you avoid these issues.
Linus
next prev parent reply other threads:[~2008-04-14 22:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-14 19:40 Davide Libenzi
2008-04-14 22:48 ` Linus Torvalds [this message]
2008-04-14 23:09 ` Davide Libenzi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.1.00.0804141545530.2879@woody.linux-foundation.org \
--to=torvalds@linux-foundation.org \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=davidel@xmailserver.org \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtk.manpages@gmail.com \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®