mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] Drop "init_mm" from being exported via EXPORT_UNUSED_SYMBOL.
@ 2008-04-24 21:31 Robert P. J. Day
  2008-04-25  7:02 ` Christoph Hellwig
  0 siblings, 1 reply; 2+ messages in thread
From: Robert P. J. Day @ 2008-04-24 21:31 UTC (permalink / raw)
  To: Linux Kernel Mailing List; +Cc: Andrew Morton, mingo


Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>

---

  since this was listed as removable as of 2.6.26, does that mean its
removal can go into an appropriate tree now?  or would that mean
*after* the release of 2.6.26?

diff --git a/arch/x86/kernel/init_task.c b/arch/x86/kernel/init_task.c
index 3d01e47..5b3ce79 100644
--- a/arch/x86/kernel/init_task.c
+++ b/arch/x86/kernel/init_task.c
@@ -15,7 +15,6 @@ static struct files_struct init_files = INIT_FILES;
 static struct signal_struct init_signals = INIT_SIGNALS(init_signals);
 static struct sighand_struct init_sighand = INIT_SIGHAND(init_sighand);
 struct mm_struct init_mm = INIT_MM(init_mm);
-EXPORT_UNUSED_SYMBOL(init_mm); /* will be removed in 2.6.26 */

 /*
  * Initial thread structure.
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry:
    Have classroom, will lecture.

http://crashcourse.ca                          Waterloo, Ontario, CANADA
========================================================================

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] Drop "init_mm" from being exported via EXPORT_UNUSED_SYMBOL.
  2008-04-24 21:31 [PATCH] Drop "init_mm" from being exported via EXPORT_UNUSED_SYMBOL Robert P. J. Day
@ 2008-04-25  7:02 ` Christoph Hellwig
  0 siblings, 0 replies; 2+ messages in thread
From: Christoph Hellwig @ 2008-04-25  7:02 UTC (permalink / raw)
  To: Robert P. J. Day; +Cc: Linux Kernel Mailing List, Andrew Morton, mingo

On Thu, Apr 24, 2008 at 05:31:20PM -0400, Robert P. J. Day wrote:
> 
> Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
> 
> ---
> 
>   since this was listed as removable as of 2.6.26, does that mean its
> removal can go into an appropriate tree now?  or would that mean
> *after* the release of 2.6.26?

Davem mentioned this has valid use-cases on non-x86 architectures
because it's exposed through mm macros.  So please audit it's users and
make sure the export is only dropped for architectures where it's not
actually needed.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-04-25  7:02 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-04-24 21:31 [PATCH] Drop "init_mm" from being exported via EXPORT_UNUSED_SYMBOL Robert P. J. Day
2008-04-25  7:02 ` Christoph Hellwig

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®