* [PATCH] x86: restrict keyboard io ports reservation to make ipmi driver work
@ 2008-04-29 21:46 Thomas Gleixner
2008-04-29 22:02 ` Yinghai Lu
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Gleixner @ 2008-04-29 21:46 UTC (permalink / raw)
To: LKML; +Cc: Ingo Molnar, Helge Wagner, Peter Zijlstra, Alan Cox
From: Helge Wagner <Helge.Wagner@gefanuc.com>
On some of our (single board computer) boards (x86) we are using an
IPMI controller that uses I/O ports 0x62 and 0x66 for a KCS (keyboard
controller style) IPMI system interface.
Trying to load the openipmi driver fails, because the ports
(0x62/0x66) are reserved for keyboard. keyboard reserves the full
range 0x60-0x6F while it doesn't need to.
Reserve only ports 0x60 and 0x64 for the legacy PS/2 i8042 keyboad
controller instead of 0x60-0x6F to allow the openipmi driver to work.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
arch/x86/kernel/setup_32.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
Index: linux-2.6/arch/x86/kernel/setup_32.c
===================================================================
--- linux-2.6.orig/arch/x86/kernel/setup_32.c
+++ linux-2.6/arch/x86/kernel/setup_32.c
@@ -127,7 +127,12 @@ static struct resource standard_io_resou
}, {
.name = "keyboard",
.start = 0x0060,
- .end = 0x006f,
+ .end = 0x0060,
+ .flags = IORESOURCE_BUSY | IORESOURCE_IO
+}, {
+ .name = "keyboard",
+ .start = 0x0064,
+ .end = 0x0064,
.flags = IORESOURCE_BUSY | IORESOURCE_IO
}, {
.name = "dma page reg",
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] x86: restrict keyboard io ports reservation to make ipmi driver work
2008-04-29 21:46 [PATCH] x86: restrict keyboard io ports reservation to make ipmi driver work Thomas Gleixner
@ 2008-04-29 22:02 ` Yinghai Lu
2008-04-29 22:55 ` Thomas Gleixner
0 siblings, 1 reply; 3+ messages in thread
From: Yinghai Lu @ 2008-04-29 22:02 UTC (permalink / raw)
To: Thomas Gleixner; +Cc: LKML, Ingo Molnar, Helge Wagner, Peter Zijlstra, Alan Cox
On Tue, Apr 29, 2008 at 2:46 PM, Thomas Gleixner <tglx@linutronix.de> wrote:
> From: Helge Wagner <Helge.Wagner@gefanuc.com>
>
> On some of our (single board computer) boards (x86) we are using an
> IPMI controller that uses I/O ports 0x62 and 0x66 for a KCS (keyboard
> controller style) IPMI system interface.
>
> Trying to load the openipmi driver fails, because the ports
> (0x62/0x66) are reserved for keyboard. keyboard reserves the full
> range 0x60-0x6F while it doesn't need to.
>
> Reserve only ports 0x60 and 0x64 for the legacy PS/2 i8042 keyboad
> controller instead of 0x60-0x6F to allow the openipmi driver to work.
>
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> ---
> arch/x86/kernel/setup_32.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> Index: linux-2.6/arch/x86/kernel/setup_32.c
> ===================================================================
> --- linux-2.6.orig/arch/x86/kernel/setup_32.c
> +++ linux-2.6/arch/x86/kernel/setup_32.c
> @@ -127,7 +127,12 @@ static struct resource standard_io_resou
> }, {
> .name = "keyboard",
> .start = 0x0060,
> - .end = 0x006f,
> + .end = 0x0060,
> + .flags = IORESOURCE_BUSY | IORESOURCE_IO
> +}, {
> + .name = "keyboard",
> + .start = 0x0064,
> + .end = 0x0064,
> .flags = IORESOURCE_BUSY | IORESOURCE_IO
> }, {
> .name = "dma page reg",
> --
64 bit need to be fixed too...
{ .name = "keyboard", .start = 0x60, .end = 0x6f,
.flags = IORESOURCE_BUSY | IORESOURCE_IO },
YH
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] x86: restrict keyboard io ports reservation to make ipmi driver work
2008-04-29 22:02 ` Yinghai Lu
@ 2008-04-29 22:55 ` Thomas Gleixner
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Gleixner @ 2008-04-29 22:55 UTC (permalink / raw)
To: Yinghai Lu; +Cc: LKML, Ingo Molnar, Helge Wagner, Peter Zijlstra, Alan Cox
On Tue, 29 Apr 2008, Yinghai Lu wrote:
> On Tue, Apr 29, 2008 at 2:46 PM, Thomas Gleixner <tglx@linutronix.de> wrote:
> > From: Helge Wagner <Helge.Wagner@gefanuc.com>
> >
> > On some of our (single board computer) boards (x86) we are using an
> > IPMI controller that uses I/O ports 0x62 and 0x66 for a KCS (keyboard
> > controller style) IPMI system interface.
> >
> > Trying to load the openipmi driver fails, because the ports
> > (0x62/0x66) are reserved for keyboard. keyboard reserves the full
> > range 0x60-0x6F while it doesn't need to.
> >
> > Reserve only ports 0x60 and 0x64 for the legacy PS/2 i8042 keyboad
> > controller instead of 0x60-0x6F to allow the openipmi driver to work.
> >
> > Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> > ---
> > arch/x86/kernel/setup_32.c | 7 ++++++-
> > 1 file changed, 6 insertions(+), 1 deletion(-)
> >
> > Index: linux-2.6/arch/x86/kernel/setup_32.c
> > ===================================================================
> > --- linux-2.6.orig/arch/x86/kernel/setup_32.c
> > +++ linux-2.6/arch/x86/kernel/setup_32.c
> > @@ -127,7 +127,12 @@ static struct resource standard_io_resou
> > }, {
> > .name = "keyboard",
> > .start = 0x0060,
> > - .end = 0x006f,
> > + .end = 0x0060,
> > + .flags = IORESOURCE_BUSY | IORESOURCE_IO
> > +}, {
> > + .name = "keyboard",
> > + .start = 0x0064,
> > + .end = 0x0064,
> > .flags = IORESOURCE_BUSY | IORESOURCE_IO
> > }, {
> > .name = "dma page reg",
> > --
>
> 64 bit need to be fixed too...
> { .name = "keyboard", .start = 0x60, .end = 0x6f,
> .flags = IORESOURCE_BUSY | IORESOURCE_IO },
Doh, yes.
Thanks,
tglx
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-04-29 22:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-04-29 21:46 [PATCH] x86: restrict keyboard io ports reservation to make ipmi driver work Thomas Gleixner
2008-04-29 22:02 ` Yinghai Lu
2008-04-29 22:55 ` Thomas Gleixner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®