mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Harvey Harrison <harvey.harrison@gmail.com>
Cc: David Miller <davem@davemloft.net>,
	akpm@linux-foundation.org, jeff@garzik.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 07/10] net: fix returning void-valued expression warnings
Date: Wed, 30 Apr 2008 20:19:16 -0700 (PDT)	[thread overview]
Message-ID: <alpine.LFD.1.10.0804302016390.5994@woody.linux-foundation.org> (raw)
In-Reply-To: <1209594005.24729.127.camel@brick>



On Wed, 30 Apr 2008, Harvey Harrison wrote:
> 
> Well, in an X86_32 allyesconfig, this only trips 32 times...so it's not
> exactly common.  I agree that there is nothing _wrong_ with this, I'll
> just add Linus and see if we can just call it codingstyle ;)

I actually had a patch to sparse to _not_ complain about it, because I 
think it's one of the sane C++ extensions. I must have lost the patch and 
not sent it upstream.

So in general, I don't mind the "return void_function()" in a void 
function, I think it makes sense from a type standpoint, and sometimes 
results in cleaner code. That said, I'm also not sure it's worth breaking 
the C standard over, so I don't really mind it being fixed in the kernel 
either (but would certainly also not complain if sparse were to be changed 
to not complain)

			Linus

  parent reply	other threads:[~2008-05-01  3:19 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-30 22:03 Harvey Harrison
2008-04-30 22:08 ` David Miller
2008-04-30 22:20   ` Harvey Harrison
2008-04-30 22:21     ` David Miller
2008-05-01  3:19     ` Linus Torvalds [this message]
2008-04-30 23:31 ` Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.1.10.0804302016390.5994@woody.linux-foundation.org \
    --to=torvalds@linux-foundation.org \
    --cc=akpm@linux-foundation.org \
    --cc=davem@davemloft.net \
    --cc=harvey.harrison@gmail.com \
    --cc=jeff@garzik.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®