From: Linus Torvalds <torvalds@linux-foundation.org>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: "Carlos R. Mafra" <crmafra@ift.unesp.br>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] kernel/time.c: Silence gcc warning 'integer constant to large for long type'
Date: Fri, 2 May 2008 15:17:00 -0700 (PDT) [thread overview]
Message-ID: <alpine.LFD.1.10.0805021515120.5994@woody.linux-foundation.org> (raw)
In-Reply-To: <481B888F.3070302@zytor.com>
On Fri, 2 May 2008, H. Peter Anvin wrote:
>
> That's more or less what my other patchset does. It's a bit more complex
> (because it gets the suffixes via macros, to get the right suffixes), but most
> of it is pure cleanup of the way we handle integers in architecture includes:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/hpa/linux-2.6-inttypes.git
This is *still* wrong.
That C type prefix should be at the *define*, not the use of those macros.
The thing is, if C code needs to do
U64_C(HZ_TO_USEC_MUL32)
to use the macro HZ_TO_USEC_MUL32, then that is a *bug* in the macro.
That kind of stuff should not be visible to users of plain constants!
Linus
next prev parent reply other threads:[~2008-05-02 22:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-02 18:58 H. Peter Anvin
2008-05-02 21:14 ` Linus Torvalds
2008-05-02 21:33 ` H. Peter Anvin
2008-05-02 22:17 ` Linus Torvalds [this message]
2008-05-02 22:33 ` Linus Torvalds
2008-05-02 22:45 ` H. Peter Anvin
2008-05-02 23:23 ` H. Peter Anvin
2008-05-03 17:57 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.1.10.0805021515120.5994@woody.linux-foundation.org \
--to=torvalds@linux-foundation.org \
--cc=crmafra@ift.unesp.br \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®