mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Ingo Molnar <mingo@elte.hu>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Pavel Machek <pavel@suse.cz>,
	linux-kernel@vger.kernel.org, davej@codemonkey.org.uk,
	andi@firstfloor.org
Subject: Re: aperture_64.c: corner case wrong
Date: Wed, 4 Jun 2008 12:48:55 +0200 (CEST)	[thread overview]
Message-ID: <alpine.LFD.1.10.0806041247300.3235@apollo.tec.linutronix.de> (raw)
In-Reply-To: <20080604104438.GA5522@elte.hu>

On Wed, 4 Jun 2008, Ingo Molnar wrote:
> * Thomas Gleixner <tglx@linutronix.de> wrote:
> 
> > > So what happened with this?  Thomas has merged an "x86: 
> > > aperture_64.c: cleanups" from yourself but it appears that half of 
> > > this bugfix got applied somewhere and the below part did not?
> > 
> > Err, no. I seem to have dropped the patch completely. I'm picking it 
> > up again.
> 
> no, it was not dropped (we dont drop patches :), here are all the 
> arch/x86/kernel/aperture_64.c patches in -tip:
> 
>  earth4:~/tip> tip-log arch/x86/kernel/aperture_64.c | grep ^#
>  # x86/gart: 1edc1ab: x86: agp_gart size checking for buggy device
>  # x86/gart: 8c9fd91: x86: checking aperture size order
>  # x86/gart: 7677b2e: x86_64: allocate gart aperture from 512M
>  # x86/gart: 55c0d72: x86: clean up aperture_64.c
>  # x86/gart: 0abbc78: x86, aperture_64: use symbolic constants
>  # x86/gart: dd564d0: x86: aperture_64.c: cleanups
> 
> so it's commit dd564d0 - but that second chunk Andrew noticed indeed 
> went missing in action.

No, the patch was titled: ".... - corner case wrong" its missing and
I'm wondering why.

/me digs into git branches

Thanks,
	tglx

      reply	other threads:[~2008-06-04 10:49 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-26 19:17 Pavel Machek
2008-05-27  0:18 ` Yinghai Lu
2008-05-27  9:06   ` Pavel Machek
2008-06-02 22:30 ` Andrew Morton
2008-06-03 13:54   ` Thomas Gleixner
2008-06-04 10:44     ` Ingo Molnar
2008-06-04 10:48       ` Thomas Gleixner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.1.10.0806041247300.3235@apollo.tec.linutronix.de \
    --to=tglx@linutronix.de \
    --cc=akpm@linux-foundation.org \
    --cc=andi@firstfloor.org \
    --cc=davej@codemonkey.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=pavel@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®