From: Linus Torvalds <torvalds@linux-foundation.org>
To: Roland McGrath <roland@redhat.com>
Cc: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86_64: fix delayed signals
Date: Thu, 10 Jul 2008 18:18:37 -0700 (PDT) [thread overview]
Message-ID: <alpine.LFD.1.10.0807101806330.2936@woody.linux-foundation.org> (raw)
In-Reply-To: <20080711005243.ADE90154218@magilla.localdomain>
On Thu, 10 Jul 2008, Roland McGrath wrote:
>
> The "actual" downsides include numerous unknowns, and I always forget
> not to be surprised when you aren't scared that we have no idea what-all
> the code might actually do.
You're just grand-standing here.
The fact is, this has been "broken" for a long long time. A lot of
applications (realistically, probably _all_ current 64-bit apps) have been
tested with the old behaviour.
The thing is, I'm simply not the _least_ nervous about behavior that we've
obviously had for a long time. And you shouldn't be either - nor should
you try to make up some bogus argument to the contrary.
You should be scared about the case that IS NOT tested - which is by
definition the new behaviour (admittedly only for 64-bit apps). Claiming
anything else is just stupid and dishonest.
So stop making up _bad_ arguments. You do have a good one: the fact that
x86-32 apparently works the way it works. But then you just irritate me
with your idiotic other ones about how things are "supposed" to work.
So just be honest: you didn't have any _actual_ downsides that you knew
about. Which was what I wondered about and asked about.
Those things make a big difference when I'm just about ready to cut a new
release. This is _clearly_ not a regression (unless you talk about things
from years and years ago), and apparently you don't have any actual code
that is broken - just your expectations.
In short, it doesn't smell like something I should apply under -rc9 rules.
[ And dammit, I wish more developers would ask themselves that question:
"Does this patch need to go in when we're very late in the -rc
sequence?". Or at least not then try to grand-stand and avoid the
question I asked. ]
Linus
next prev parent reply other threads:[~2008-07-11 1:19 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-10 21:50 Roland McGrath
2008-07-10 22:06 ` Linus Torvalds
2008-07-10 22:42 ` Roland McGrath
2008-07-10 22:51 ` Linus Torvalds
2008-07-10 23:02 ` Linus Torvalds
2008-07-11 0:52 ` Roland McGrath
2008-07-11 1:18 ` Linus Torvalds [this message]
2008-07-11 1:27 ` Roland McGrath
2008-07-11 1:48 ` Linus Torvalds
2008-07-11 2:02 ` Linus Torvalds
2008-07-11 2:22 ` Linus Torvalds
2008-07-11 2:26 ` Linus Torvalds
2008-07-12 12:24 ` Andi Kleen
2008-07-11 5:46 ` Ingo Molnar
2008-07-11 11:13 ` Török Edwin
2008-07-11 12:24 ` Elias Oltmanns
2008-07-11 17:58 ` Linus Torvalds
2008-07-11 18:07 ` Roland McGrath
2008-07-11 18:16 ` Linus Torvalds
2008-07-11 18:17 ` Linus Torvalds
2008-07-11 18:10 ` Linus Torvalds
2008-07-11 18:31 ` Linus Torvalds
2008-07-11 22:53 ` Arjan van de Ven
2008-07-12 10:33 ` Török Edwin
2008-07-11 20:37 ` Linus Torvalds
2008-07-11 23:22 ` Linus Torvalds
2008-07-12 10:32 ` Török Edwin
2008-07-12 13:42 ` Török Edwin
2008-07-12 14:55 ` Arjan van de Ven
2008-07-12 18:00 ` Linus Torvalds
2008-07-12 18:15 ` Arjan van de Ven
2008-07-12 18:28 ` Linus Torvalds
2008-07-12 17:29 ` Linus Torvalds
2008-07-12 20:26 ` Török Edwin
2008-07-12 20:47 ` Linus Torvalds
2008-07-12 20:57 ` Denys Vlasenko
2008-07-13 10:46 ` Oleg Nesterov
2008-07-13 12:34 ` Denys Vlasenko
2008-07-13 18:36 ` Linus Torvalds
2008-07-13 18:45 ` Peter T. Breuer
2008-07-12 12:27 ` Andi Kleen
2008-07-12 17:41 ` Linus Torvalds
2008-07-13 9:38 ` Andi Kleen
2008-07-13 17:32 ` Linus Torvalds
2008-07-13 18:59 ` Andi Kleen
2008-07-13 19:08 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.1.10.0807101806330.2936@woody.linux-foundation.org \
--to=torvalds@linux-foundation.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=roland@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®