From: Linus Torvalds <torvalds@linux-foundation.org>
To: Avi Kivity <avi@qumranet.com>
Cc: Ingo Molnar <mingo@elte.hu>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [git pull] core, x86: make LIST_POISON less deadly
Date: Mon, 14 Jul 2008 09:26:33 -0700 (PDT) [thread overview]
Message-ID: <alpine.LFD.1.10.0807140917050.3305@woody.linux-foundation.org> (raw)
In-Reply-To: <487B7A10.9050104@qumranet.com>
On Mon, 14 Jul 2008, Avi Kivity wrote:
>
> We could add a printk to the #GP handler that alerts the reader that a
> poisoned list is suspected, if we find the address pattern in one of the
> registers.
I wouldn't worry too much - it's going to be pretty visible anyway.
The only thing I _would_ worry about is the AMD prefetch bug - some AMD
cores raise a spurious page fault for prefetch instructions, and we ignore
it.
I _think_ that bug is a pure TLB issue and would never trigger for an
address that doesn't do page fault handling at all because it gets caught
in the "is the address valid" code, but it does make me go "Hmm".
See
http://lkml.org/lkml/2003/9/10/397
from Rich Brunner. The AMD errata listing does say just page fault, and
does talk about speculative TLB reloads, so I think we're all good.
Linus
next prev parent reply other threads:[~2008-07-14 16:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-14 14:48 Ingo Molnar
2008-07-14 15:03 ` Linus Torvalds
2008-07-14 15:12 ` Ingo Molnar
2008-07-14 15:53 ` Avi Kivity
2008-07-14 15:59 ` Linus Torvalds
2008-07-14 16:07 ` Ingo Molnar
2008-07-14 16:08 ` Avi Kivity
2008-07-14 16:26 ` Linus Torvalds [this message]
2008-07-14 16:34 ` Ingo Molnar
2008-07-14 18:33 ` Andi Kleen
2008-07-14 18:42 ` Linus Torvalds
2008-07-14 19:11 ` Andi Kleen
2008-07-14 19:30 ` Linus Torvalds
2008-07-14 19:42 ` Andi Kleen
2008-07-14 18:35 ` Andi Kleen
2008-07-14 18:42 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.1.10.0807140917050.3305@woody.linux-foundation.org \
--to=torvalds@linux-foundation.org \
--cc=akpm@linux-foundation.org \
--cc=avi@qumranet.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®