mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Andi Kleen <andi@firstfloor.org>
Cc: Ray Lee <ray-lk@madrabbit.org>,
	Jesse Barnes <jbarnes@virtuousgeek.org>,
	"Rafael J. Wysocki" <rjw@sisk.pl>,
	torvalds@linuxfoundation.org, linux-kernel@vger.kernel.org,
	linux-acpi@vger.kernel.org
Subject: Re: Please pull ACPI updates
Date: Thu, 17 Jul 2008 13:01:17 -0700 (PDT)	[thread overview]
Message-ID: <alpine.LFD.1.10.0807171259010.2959@woody.linux-foundation.org> (raw)
In-Reply-To: <487FA24B.9060803@firstfloor.org>


On Thu, 17 Jul 2008, Andi Kleen wrote:
> 
> The whole point of the exercise of cleaning up/rewriting the history is to make
> the tree as bisectable as possible.

No.

"git bisect" is perfetly able to handle merges. They are _fine_.

The problem with rebasing is that it *changes* something that was already 
tested (and possibly merged into somebody elses tree) into SOMETHING ELSE.

And that means that a large portion of the previous testing is basically 
thrown away.

In particular, if something worked for somebody before, it also removes 
the "known good state" from a bisection standpoint, so rebasing actually 
makes things _harder_ to bisect - because now you cannot sanely bisect 
between two versions of the tree (when you mark the old tree "good", it 
has no relevance to the new tree that had all the old history rewritten).

So no, rebasing does _not_ make bisection easier. It makes it easier to 
understand, perhaps, but it actually makes many things much much harder, 
and removes all trace of any testing coverage that the old commit had.

			Linus

  reply	other threads:[~2008-07-17 20:01 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-16 21:45 Andi Kleen
2008-07-16 22:11 ` Rafael J. Wysocki
2008-07-16 23:33   ` Jesse Barnes
2008-07-16 23:45     ` Linus Torvalds
2008-07-16 23:51       ` Jesse Barnes
2008-07-17  0:32         ` Linus Torvalds
2008-07-17  0:53           ` Linus Torvalds
2008-07-17  2:26             ` Jesse Barnes
2008-07-17  2:56               ` Linus Torvalds
2008-07-17  6:45           ` Andi Kleen
2008-07-17 15:06             ` Linus Torvalds
2008-07-17  6:40       ` Andi Kleen
2008-07-17 15:03         ` Linus Torvalds
2008-07-17 18:49           ` Len Brown
2008-07-17 19:12             ` Harvey Harrison
2008-07-17 19:50               ` Andi Kleen
2008-07-17 19:12             ` Linus Torvalds
2008-07-17 19:16               ` Linus Torvalds
2008-07-17 21:15             ` J. Bruce Fields
2008-07-17 23:11           ` [PATCH] Revert duplicate "dock: bay: Don't call acpi_walk_namespace() when ACPI is disabled" commit (was: Please pull ACPI updates) Thomas Gleixner
2008-07-17 23:25             ` [PATCH] Revert duplicate "dock: bay: Don't call acpi_walk_namespace() when ACPI is disabled" commit Andi Kleen
2008-07-18  0:07             ` [PATCH] Revert duplicate "ACPI: don't walk tables if ACPI was disabled" commit (was: Please pull ACPI updates) Thomas Gleixner
2008-07-17  6:47     ` Please pull ACPI updates Andi Kleen
2008-07-17 15:18       ` Linus Torvalds
2008-07-17 15:47         ` Linus Torvalds
2008-07-17 16:02           ` Linus Torvalds
2008-07-17 16:23           ` Andi Kleen
2008-07-17 19:11             ` Ray Lee
2008-07-17 19:49               ` Andi Kleen
2008-07-17 20:01                 ` Linus Torvalds [this message]
2008-07-17 20:14                   ` Andi Kleen
2008-07-17 20:16                   ` Linus Torvalds
2008-07-17 20:28                     ` Linus Torvalds
2008-07-18 13:25                       ` Olivier Galibert
2008-07-18 15:57                         ` Ray Lee
2008-07-17 20:34                     ` Andi Kleen
2008-07-17 20:11                 ` Ray Lee
2008-07-17 20:29                   ` Andi Kleen
2008-07-18  6:39                     ` david
2008-07-24 20:36 Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.1.10.0807171259010.2959@woody.linux-foundation.org \
    --to=torvalds@linux-foundation.org \
    --cc=andi@firstfloor.org \
    --cc=jbarnes@virtuousgeek.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ray-lk@madrabbit.org \
    --cc=rjw@sisk.pl \
    --cc=torvalds@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®