mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Andreas Herrmann <andreas.herrmann3@amd.com>
Cc: Valdis.Kletnieks@vt.edu, Ingo Molnar <mingo@elte.hu>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86: c1e_idle: don't mark TSC unstable if CPU has invariant TSC
Date: Fri, 19 Sep 2008 11:21:19 -0700 (PDT)	[thread overview]
Message-ID: <alpine.LFD.1.10.0809191119250.3650@apollo.tec.linutronix.de> (raw)
In-Reply-To: <20080919172019.GA16896@alberich.amd.com>

On Fri, 19 Sep 2008, Andreas Herrmann wrote:
> TSC on K8 is not P-state and C-state invariant.
> Thus on K8 you'll have a TSC drift if C1E is entered.
> 
> This means that if C1E is enabled TSC should be marked unstable on
> those CPUs (it shouldn't be used as a clocksource).

Correct. I missed that detail with the newer CPUs when I did the C1E
idle stuff. Thanks for catching it. I'll schedule it for Linus when
I'm back from Portland.

Thanks,

	tglx

  reply	other threads:[~2008-09-19 18:21 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-18 19:12 Andreas Herrmann
2008-09-18 19:35 ` Valdis.Kletnieks
2008-09-19 17:20   ` Andreas Herrmann
2008-09-19 18:21     ` Thomas Gleixner [this message]
2008-09-20  6:14     ` Ingo Molnar
2008-09-23  5:42       ` Andreas Herrmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.1.10.0809191119250.3650@apollo.tec.linutronix.de \
    --to=tglx@linutronix.de \
    --cc=Valdis.Kletnieks@vt.edu \
    --cc=andreas.herrmann3@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®