From: "Maciej W. Rozycki" <macro@linux-mips.org>
To: Luca Tiburzio <luca.tiburzio@gmail.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: PHYLIB dependency in kernel 2.6.27.6
Date: Wed, 19 Nov 2008 14:09:33 +0000 (GMT) [thread overview]
Message-ID: <alpine.LFD.1.10.0811191359170.22228@ftp.linux-mips.org> (raw)
In-Reply-To: <a278970e0811161427r2f941e10jafbc8ab1d425d64e@mail.gmail.com>
On Sun, 16 Nov 2008, Luca Tiburzio wrote:
> in make process of linux 2.6.27.6 the PHYLIB depends on
>
> NETDEVICES && !S390 && NET_ETHERNET
>
> but if I enable only
>
> Ethernet (1000 Mbit) (NETDEV_1000)
> i loose visibility of PHYLIB
>
> it should be better that PHYLIB depends on:
> NETDEVICES && !S390 && (NET_ETHERNET || NETDEV_1000)
Well, practice shows selecting PHYLIB via a reverse dependency is
probably the most reasonable approach, but given the option is enabled for
explicit selection otherwise for legacy Ethernet devices, it may make
sense to do so for Gigabit devices too. Not sure about 10Gb, but here is
a patch from my pile I prepared a while ago, but haven't submitted it
yet. Feel free to push it further if you find it useful. Please note
netdev is the right list for networking matters.
Maciej
---
Make PHYLIB available for selection for NETDEV_1000 too.
Signed-off-by: Maciej W. Rozycki <macro@linux-mips.org>
---
patch-2.6.26-rc1-20080505-phy-1000-1
diff -up --recursive --new-file linux-2.6.26-rc1-20080505.macro/drivers/net/phy/Kconfig linux-2.6.26-rc1-20080505/drivers/net/phy/Kconfig
--- linux-2.6.26-rc1-20080505.macro/drivers/net/phy/Kconfig 2008-05-17 05:57:43.000000000 +0000
+++ linux-2.6.26-rc1-20080505/drivers/net/phy/Kconfig 2008-05-17 06:09:49.000000000 +0000
@@ -5,7 +5,7 @@
menuconfig PHYLIB
tristate "PHY Device support and infrastructure"
depends on !S390
- depends on NET_ETHERNET
+ depends on NET_ETHERNET || NETDEV_1000
help
Ethernet controllers are usually attached to PHY
devices. This option provides infrastructure for
prev parent reply other threads:[~2008-11-19 14:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-16 22:27 Luca Tiburzio
2008-11-19 14:09 ` Maciej W. Rozycki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.1.10.0811191359170.22228@ftp.linux-mips.org \
--to=macro@linux-mips.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luca.tiburzio@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®