PHYLIB dependency in kernel 2.6.27.6

PHYLIB dependency in kernel 2.6.27.6

[Luca Tiburzio]

Hi to all,
in make process of linux 2.6.27.6 the PHYLIB depends on

NETDEVICES && !S390 && NET_ETHERNET

but if I enable only

Ethernet (1000 Mbit) (NETDEV_1000)
i loose visibility of PHYLIB

it should be better that  PHYLIB depends on:
NETDEVICES && !S390 && (NET_ETHERNET || NETDEV_1000)

Have a nice day.
Luca

Re: PHYLIB dependency in kernel 2.6.27.6

[Maciej W. Rozycki]

On Sun, 16 Nov 2008, Luca Tiburzio wrote:

> in make process of linux 2.6.27.6 the PHYLIB depends on
> 
> NETDEVICES && !S390 && NET_ETHERNET
> 
> but if I enable only
> 
> Ethernet (1000 Mbit) (NETDEV_1000)
> i loose visibility of PHYLIB
> 
> it should be better that  PHYLIB depends on:
> NETDEVICES && !S390 && (NET_ETHERNET || NETDEV_1000)

 Well, practice shows selecting PHYLIB via a reverse dependency is 
probably the most reasonable approach, but given the option is enabled for 
explicit selection otherwise for legacy Ethernet devices, it may make 
sense to do so for Gigabit devices too.  Not sure about 10Gb, but here is 
a patch from my pile I prepared a while ago, but haven't submitted it 
yet.  Feel free to push it further if you find it useful.  Please note 
netdev is the right list for networking matters.

  Maciej

---
 Make PHYLIB available for selection for NETDEV_1000 too.

Signed-off-by: Maciej W. Rozycki <macro@linux-mips.org>
---
patch-2.6.26-rc1-20080505-phy-1000-1
diff -up --recursive --new-file linux-2.6.26-rc1-20080505.macro/drivers/net/phy/Kconfig linux-2.6.26-rc1-20080505/drivers/net/phy/Kconfig
--- linux-2.6.26-rc1-20080505.macro/drivers/net/phy/Kconfig	2008-05-17 05:57:43.000000000 +0000
+++ linux-2.6.26-rc1-20080505/drivers/net/phy/Kconfig	2008-05-17 06:09:49.000000000 +0000
@@ -5,7 +5,7 @@
 menuconfig PHYLIB
 	tristate "PHY Device support and infrastructure"
 	depends on !S390
-	depends on NET_ETHERNET
+	depends on NET_ETHERNET || NETDEV_1000
 	help
 	  Ethernet controllers are usually attached to PHY
 	  devices.  This option provides infrastructure for