From: Thomas Gleixner <tglx@linutronix.de>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Maciej Rutecki <maciej.rutecki@gmail.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@elte.hu>,
Rusty Russell <rusty@rustcorp.com.au>
Subject: Re: [Linux 2.6.29-rc2] BUG: using smp_processor_id() in preemptible
Date: Sun, 25 Jan 2009 12:57:47 +0100 (CET) [thread overview]
Message-ID: <alpine.LFD.2.00.0901251254370.3424@localhost.localdomain> (raw)
In-Reply-To: <20090124183746.395f597b.akpm@linux-foundation.org>
On Sat, 24 Jan 2009, Andrew Morton wrote:
>
> Coming out of the hrtimer_hres_active() call, I assume.
Yes.
> Is this new behaviour, or were 2.6.28 and earlier doing it?
This code is there since highres was merged, but something seems to
have changed in the suspend/resume code as I'm pretty sure, that this
code was always called with interrupts disabled.
> a) remove the wrong "Called with interrupts disabled via
> on_each_cpu()" comment from retrigger_next_event(), and replace it
> with something useful and truthful.
Good point.
> b) change hres_timers_resume() to do local_irq_save/restore
Right, but I'd like to know what changed below.
Thanks,
tglx
next prev parent reply other threads:[~2009-01-25 11:58 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-17 8:58 Maciej Rutecki
2009-01-25 2:37 ` Andrew Morton
2009-01-25 11:57 ` Thomas Gleixner [this message]
2009-01-25 14:19 ` Maciej Rutecki
2009-01-25 16:30 ` Maciej Rutecki
2009-01-26 16:07 ` Linus Torvalds
2009-01-26 16:53 ` Rafael J. Wysocki
2009-01-26 17:41 ` Ingo Molnar
2009-01-26 19:21 ` Rafael J. Wysocki
2009-01-26 20:35 ` Ingo Molnar
2009-01-26 20:48 ` Rafael J. Wysocki
2009-01-26 21:35 ` Ingo Molnar
2009-01-27 15:28 ` Rafael J. Wysocki
2009-01-27 15:49 ` Ingo Molnar
2009-01-27 21:18 ` Rafael J. Wysocki
2009-01-29 15:07 ` Ingo Molnar
2009-01-29 22:29 ` Rafael J. Wysocki
2009-01-30 14:06 ` Ingo Molnar
2009-01-30 21:30 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.0901251254370.3424@localhost.localdomain \
--to=tglx@linutronix.de \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maciej.rutecki@gmail.com \
--cc=mingo@elte.hu \
--cc=rjw@sisk.pl \
--cc=rusty@rustcorp.com.au \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®