From: Thomas Gleixner <tglx@linutronix.de>
To: mtk.manpages@gmail.com
Cc: LKML <linux-kernel@vger.kernel.org>,
Roland McGrath <roland@redhat.com>,
Oleg Nesterov <oleg@tv-sign.ru>, Ingo Molnar <mingo@elte.hu>,
Linux API <linux-api@vger.kernel.org>
Subject: Re: [patch 0/3] add rt_tgsigqueueinfo syscall [RESEND]
Date: Thu, 26 Feb 2009 23:13:33 +0100 (CET) [thread overview]
Message-ID: <alpine.LFD.2.00.0902262311350.9135@localhost.localdomain> (raw)
In-Reply-To: <cfd18e0f0902261319v20ba7bd1pcc91ccc4b2c7d577@mail.gmail.com>
Michael,
On Fri, 27 Feb 2009, Michael Kerrisk wrote:
> I haven't looked at this iteration of the patch, to check if it is
> different from the version you posted a few months ago. I assume it
> isn't different, since you didn't mention any differences. In that
> case, there are still the questions I raised back then, so I'll just
> repeat them now.
Right, no fundamental changes.
> Back in October, I did some testing of this interface. Two potential
> issues that I saw, both of which relate to inconsistencies with
> rt_sigqueueinfo():
>
> 1) With rt_siqueueinfo(), we can get the PID (TGID) of the sender,
> which enables the receiver of the signal to know who the sender was,
> and perhaps use that information to (for example) send a signal in the
> other direction.
>
> With rt_tgsigqueueinfo(), we don't quite have that ability: all that
> the receiver gets is the TGID of the sender, not the TID. This means
> that we can't (for example) send a signal back to the precise thread
> that signaled us. I'm not sure if this matters or not (but perhaps it
> might when sender and receiver are in the same process?). I'm also
> not sure whether we want to do anything about this (i.e., extending
> siginfo_t to include a si_tid field), but I wanted to point out this
> assymetry w.r.t. to rt_sigqueueinfo(), in case you had not considered
> it.
>
> 2) With rt_sigqueueinfo(), we can specify the si_pid and and si_uid
> fields that should be sent to the receiver. This is not possible with
> rt_tgsigqueueinfo(), which always supplied the caller';s PID and UID
> in the si_pid and si_uid fields sent to the receiver. See the
> following, created using my test programs below (the 111 & 222
> arguments to t_*sigqueueinfo set the si_pid and si_uid fields in the
> siginfo_t given to the *sigqueueinfo() syscall):
I can see your concern, but I have no strong opinion in either
direction.
Roland ??
Thanks,
tglx
next prev parent reply other threads:[~2009-02-26 22:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-26 13:35 Thomas Gleixner
2009-02-26 13:35 ` [patch 1/3] signals: split do_tkill Thomas Gleixner
2009-02-26 13:35 ` [patch 2/3] signals: implement sys_rt_tgsigqueueinfo Thomas Gleixner
2009-02-26 13:35 ` [patch 3/3] x86: hookup sys_rt_tgsigqueueinfo Thomas Gleixner
2009-02-26 21:19 ` [patch 0/3] add rt_tgsigqueueinfo syscall [RESEND] Michael Kerrisk
2009-02-26 22:13 ` Thomas Gleixner [this message]
2009-02-28 1:53 ` Michael Kerrisk
2009-02-28 2:44 ` Roland McGrath
2009-02-28 8:46 ` Michael Kerrisk
2009-02-27 0:03 ` Roland McGrath
2009-03-23 11:14 ` Thomas Gleixner
2009-03-24 6:58 ` Roland McGrath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.0902262311350.9135@localhost.localdomain \
--to=tglx@linutronix.de \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mtk.manpages@gmail.com \
--cc=oleg@tv-sign.ru \
--cc=roland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®