Re: Add '-fwrapv' to gcc CFLAGS

Re: Add '-fwrapv' to gcc CFLAGS

[Sam Ravnborg]

On Thu, Mar 19, 2009 at 09:59:01PM +0000, Linux Kernel Mailing List wrote:
> Gitweb:     http://git.kernel.org/linus/68df3755e383e6fecf2354a67b08f92f18536594
> Commit:     68df3755e383e6fecf2354a67b08f92f18536594
> Parent:     a1e4ee22863d41a6fbb24310d7951836cb6dafe7
> Author:     Linus Torvalds <torvalds@linux-foundation.org>
> AuthorDate: Thu Mar 19 11:10:17 2009 -0700
> Committer:  Linus Torvalds <torvalds@linux-foundation.org>
> CommitDate: Thu Mar 19 11:10:17 2009 -0700
> 
>     Add '-fwrapv' to gcc CFLAGS
>     
>     This makes sure that gcc doesn't try to optimize away wrapping
>     arithmetic, which the kernel occasionally uses for overflow testing, ie
>     things like
>     
>     	if (ptr + offset < ptr)
>     
>     which technically is undefined for non-unsigned types. See
>     
>     	http://bugzilla.kernel.org/show_bug.cgi?id=12597
>     
>     for details.
>     
>     Not all versions of gcc support it, so we need to make it conditional
>     (it looks like it was introduced in gcc-3.4).
>     
>     Reminded-by: Alan Cox <alan@lxorguk.ukuu.org.uk>
>     Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
> ---
>  Makefile |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/Makefile b/Makefile
> index 2e2f4a4..f607658 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -347,6 +347,7 @@ KBUILD_CPPFLAGS := -D__KERNEL__
>  KBUILD_CFLAGS   := -Wall -Wundef -Wstrict-prototypes -Wno-trigraphs \
>  		   -fno-strict-aliasing -fno-common \
>  		   -Werror-implicit-function-declaration
> +KBUILD_CFLAGS	+= $(call cc-option,-fwrapv)
>  KBUILD_AFLAGS   := -D__ASSEMBLY__
>  
>  # Read KERNELRELEASE from include/config/kernel.release (if it exists)

Path is buggy.
We have several architectures that plays strange games with $(CC)
and $(CROSS_COMPILE).
So we need to postpone any use of $(call cc-option..)
until we have included the arch specific Makefile so
we try with the correct $(CC) version.

If you move it below the include at around line 530 you
should be safe.

	Sam

Re: Add '-fwrapv' to gcc CFLAGS

[Linus Torvalds]

On Thu, 19 Mar 2009, Sam Ravnborg wrote:
> 
> Path is buggy.
> We have several architectures that plays strange games with $(CC)
> and $(CROSS_COMPILE).

Argh. It looked obvious, and worked for me, but..

> So we need to postpone any use of $(call cc-option..)
> until we have included the arch specific Makefile so
> we try with the correct $(CC) version.
> 
> If you move it below the include at around line 530 you
> should be safe.

Will do.

		Linus