From: Thomas Gleixner <tglx@linutronix.de>
To: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: Steven Rostedt <rostedt@goodmis.org>,
linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
Peter Zijlstra <peterz@infradead.org>,
Roland McGrath <roland@redhat.com>,
Nick Piggin <nickpiggin@yahoo.com.au>,
Steven Rostedt <srostedt@redhat.com>,
Christoph Lameter <cl@linux-foundation.org>,
Matt Mackall <mpm@selenic.com>
Subject: Re: [PATCH 2/5] mm: remove unlikly NULL from kfree
Date: Wed, 25 Mar 2009 08:50:44 +0100 (CET) [thread overview]
Message-ID: <alpine.LFD.2.00.0903250840440.29264@localhost.localdomain> (raw)
In-Reply-To: <84144f020903250034j24e1782bt5f73809b9349346c@mail.gmail.com>
On Wed, 25 Mar 2009, Pekka Enberg wrote:
> On Wed, Mar 25, 2009 at 7:19 AM, Steven Rostedt <rostedt@goodmis.org> wrote:
> > This makes sense, since we now encourage developers to just call kfree
> > without checking for NULL.
>
> But those are _error handling paths_ (at least supposed to be). I
> wonder which call-sites are responsible for this. Can frtrace help us
> here?
Why is this an error handler. We replaced tons of
if (obj)
kfree(obj);
constructs all over the kernel with kfree(obj); and let kfree deal
with the NULL pointer.
Thanks,
tglx
next prev parent reply other threads:[~2009-03-25 7:53 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-25 5:19 [PATCH 0/5] [PATCH][GIT PULL] remove unnecessary (un)likelys Steven Rostedt
2009-03-25 5:19 ` [PATCH 1/5] ptrace: remove incorrect unlikelys Steven Rostedt
2009-03-25 7:21 ` Ingo Molnar
2009-03-25 13:31 ` Christian Borntraeger
2009-03-25 13:42 ` Steven Rostedt
2009-03-25 9:28 ` Roland McGrath
2009-03-25 5:19 ` [PATCH 2/5] mm: remove unlikly NULL from kfree Steven Rostedt
2009-03-25 7:34 ` Pekka Enberg
2009-03-25 7:50 ` Thomas Gleixner [this message]
2009-03-25 8:01 ` Pekka Enberg
2009-03-25 21:20 ` Andrew Morton
2009-03-25 8:02 ` Hua Zhong
2009-03-25 8:06 ` Pekka Enberg
2009-03-25 13:51 ` Pekka Enberg
2009-03-25 14:47 ` Steven Rostedt
2009-03-25 14:59 ` Pekka Enberg
2009-03-25 15:04 ` Steven Rostedt
2009-03-25 15:08 ` Steven Rostedt
2009-03-25 16:14 ` Matt Mackall
2009-03-25 16:34 ` Steven Rostedt
2009-03-25 20:26 ` Jeremy Fitzhardinge
2009-03-25 21:09 ` Matt Mackall
2009-03-25 21:01 ` Matt Mackall
2009-03-25 21:24 ` Steven Rostedt
2009-03-25 15:27 ` Steven Rostedt
2009-03-26 16:10 ` Al Viro
2009-03-26 16:15 ` Andrew Morton
2009-03-25 5:19 ` [PATCH 3/5] sched: remove unlikely in pre_schedule_rt Steven Rostedt
2009-03-25 5:24 ` Steven Rostedt
2009-03-25 5:19 ` [PATCH 4/5] sched: remove unlikelys from sched_move_task Steven Rostedt
2009-03-25 5:19 ` [PATCH 5/5] mm: remove unlikelys for unlock in rmap.c Steven Rostedt
2009-04-24 11:12 ` KOSAKI Motohiro
2009-04-24 12:15 ` Lee Schermerhorn
2009-03-25 7:19 ` [PATCH 0/5] [PATCH][GIT PULL] remove unnecessary (un)likelys Ingo Molnar
2009-03-25 7:25 ` Ingo Molnar
2009-03-25 13:43 ` Steven Rostedt
2009-04-27 16:30 ` Daniel Walker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.0903250840440.29264@localhost.localdomain \
--to=tglx@linutronix.de \
--cc=akpm@linux-foundation.org \
--cc=cl@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mpm@selenic.com \
--cc=nickpiggin@yahoo.com.au \
--cc=penberg@cs.helsinki.fi \
--cc=peterz@infradead.org \
--cc=roland@redhat.com \
--cc=rostedt@goodmis.org \
--cc=srostedt@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®