* [PATCH] UM: Remove BKL from sys_execve
@ 2009-10-18 14:36 John Kacur
0 siblings, 0 replies; only message in thread
From: John Kacur @ 2009-10-18 14:36 UTC (permalink / raw)
To: linux-kernel, Thomas Gleixner
Cc: Arnd Bergmann, Alan Cox, Ingo Molnar, Frederic Weisbecker, Jeff Dike
>From 4d71a5e17b985a8fefaa88e3a6fe4896878886ba Mon Sep 17 00:00:00 2001
From: John Kacur <jkacur@redhat.com>
Date: Sun, 18 Oct 2009 16:17:57 +0200
Subject: [PATCH] UM: Remove BKL from sys_execve
The BKL in sys_execve is likely the result of a cut-and-paste from a time,
when it was needed. However, it is no longer required here. Remove to be
in sync with other architectures.
(See arch/x86/kernel/process_64.c for example)
Signed-off-by: John Kacur <jkacur@redhat.com>
---
arch/um/kernel/exec.c | 7 ++-----
1 files changed, 2 insertions(+), 5 deletions(-)
diff --git a/arch/um/kernel/exec.c b/arch/um/kernel/exec.c
index fda30d2..d39aa36 100644
--- a/arch/um/kernel/exec.c
+++ b/arch/um/kernel/exec.c
@@ -5,7 +5,6 @@
#include "linux/stddef.h"
#include "linux/fs.h"
-#include "linux/smp_lock.h"
#include "linux/ptrace.h"
#include "linux/sched.h"
#include "asm/current.h"
@@ -76,13 +75,11 @@ long sys_execve(char __user *file, char __user *__user *argv,
long error;
char *filename;
- lock_kernel();
filename = getname(file);
error = PTR_ERR(filename);
- if (IS_ERR(filename)) goto out;
+ if (IS_ERR(filename))
+ return error;
error = execve1(filename, argv, env);
putname(filename);
- out:
- unlock_kernel();
return error;
}
--
1.6.0.6
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2009-10-18 14:37 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-10-18 14:36 [PATCH] UM: Remove BKL from sys_execve John Kacur
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®