From: Linus Torvalds <torvalds@linux-foundation.org>
To: Yinghai Lu <yinghai@kernel.org>
Cc: Suresh Siddha <suresh.b.siddha@intel.com>,
"ananth@in.ibm.com" <ananth@in.ibm.com>,
Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 4/4] x86: according to nr_cpu_ids to decide if need to leave logical flat
Date: Mon, 11 Jan 2010 19:20:29 -0800 (PST) [thread overview]
Message-ID: <alpine.LFD.2.00.1001111917190.17145@localhost.localdomain> (raw)
In-Reply-To: <1263264483-3959-3-git-send-email-yinghai@kernel.org>
On Mon, 11 Jan 2010, Yinghai Lu wrote:
> +
> +void default_setup_apic_routing(void)
Good cleanup, makes x86-64 and x86-32 look similar. However, you should
mark it __init too, I think, to match the current probe_64.c thing.
Also, what about the default_setup_apic_routing() call in
arch/x86/kernel/apic/apic.c? Is that not ripe for unification too now? You
only did the smpboot.c one, not the APIC_init_uniprocessor() one.
Hmm?
Linus
next prev parent reply other threads:[~2010-01-12 3:22 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-12 2:48 [RFC PATCH 1/4] use nr_cpus= to set nr_cpu_ids early Yinghai Lu
2010-01-12 2:48 ` [RFC PATCH 3/4] x86: using logical flat for amd cpu too Yinghai Lu
2010-01-12 3:16 ` Linus Torvalds
2010-01-12 8:47 ` Yinghai Lu
2010-01-12 8:27 ` Ananth N Mavinakayanahalli
2010-01-12 22:50 ` H. Peter Anvin
2010-01-13 4:53 ` Ananth N Mavinakayanahalli
2010-01-12 2:48 ` [RFC PATCH 4/4] x86: according to nr_cpu_ids to decide if need to leave logical flat Yinghai Lu
2010-01-12 3:20 ` Linus Torvalds [this message]
2010-01-12 8:50 ` Yinghai Lu
2010-01-12 2:48 ` [RFC PATCH 2/4] x86: use dmi check to treat disabled cpus as hotplug cpus Yinghai Lu
2010-01-12 3:13 ` Linus Torvalds
2010-01-12 8:59 ` Yinghai Lu
2010-01-12 15:19 ` Linus Torvalds
2010-01-12 17:54 ` Suresh Siddha
2010-01-12 18:13 ` Yinghai Lu
2010-01-12 18:24 ` Suresh Siddha
2010-01-12 19:19 ` Yinghai Lu
2010-01-12 9:15 ` Yinghai Lu
2010-01-12 9:46 ` Ingo Molnar
2010-01-12 16:14 ` Valdis.Kletnieks
2010-01-12 16:26 ` Linus Torvalds
2010-01-12 17:17 ` Valdis.Kletnieks
2010-01-12 3:06 ` [RFC PATCH 1/4] use nr_cpus= to set nr_cpu_ids early Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.1001111917190.17145@localhost.localdomain \
--to=torvalds@linux-foundation.org \
--cc=akpm@linux-foundation.org \
--cc=ananth@in.ibm.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=suresh.b.siddha@intel.com \
--cc=tglx@linutronix.de \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®