From: Linus Torvalds <torvalds@linux-foundation.org>
To: Greg KH <greg@kroah.com>
Cc: Markus Rechberger <mrechberger@gmail.com>,
linux-usb@vger.kernel.org, werner@guyane.dyn-o-saur.com,
Marcus Meissner <meissner@suse.de>,
linux-kernel@vger.kernel.org
Subject: Re: 2.6.33 bugs (USBFS, Intel graphic)
Date: Fri, 26 Feb 2010 20:29:28 -0800 (PST) [thread overview]
Message-ID: <alpine.LFD.2.00.1002262022090.4513@localhost.localdomain> (raw)
In-Reply-To: <20100227041815.GA12956@kroah.com>
On Fri, 26 Feb 2010, Greg KH wrote:
>
> Yes, and that patch didn't touch the iso frames. That happens later on
> in the functions that were modified. The patch should not have had any
> affect on iso transfers. Unless I'm missing something?
Hmm. What seems to happen is that for an isochronous transfer, the buffer
is split for each microframe. No?
So the total length may be in 'urb->actual_length', but the actual data in
the buffer may not be contiguous, because it's created from multiple
smaller frames, some of which might not be full length?
I dunno. That would explain the problem - actual_length is correct, but
the 'copy_to_user()' still doesn't copy all the data, because it's
fragmented.
Linus
next prev parent reply other threads:[~2010-02-27 4:29 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-27 3:42 Markus Rechberger
2010-02-27 3:56 ` Greg KH
2010-02-27 4:05 ` Markus Rechberger
2010-02-27 4:18 ` Greg KH
2010-02-27 4:29 ` Linus Torvalds [this message]
2010-02-27 4:34 ` Markus Rechberger
2010-02-27 5:17 ` Greg KH
2010-02-27 5:26 ` Greg KH
2010-02-27 5:38 ` Markus Rechberger
2010-02-27 5:48 ` Greg KH
2010-02-27 11:00 ` Markus Rechberger
2010-02-27 12:15 ` Pekka Enberg
2010-02-27 12:17 ` Pekka Enberg
2010-02-27 16:49 ` Jesse Barnes
2010-02-27 18:08 ` Markus Rechberger
2010-02-27 22:33 ` Markus Rechberger
2010-02-27 17:20 ` Alan Stern
2010-03-03 0:09 ` Greg KH
2010-03-05 21:37 ` Markus Rechberger
2010-03-06 16:30 ` Markus Rechberger
2010-03-06 17:06 ` Greg KH
2010-03-06 20:04 ` Alan Stern
2010-02-27 4:11 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.1002262022090.4513@localhost.localdomain \
--to=torvalds@linux-foundation.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=meissner@suse.de \
--cc=mrechberger@gmail.com \
--cc=werner@guyane.dyn-o-saur.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome