From: Markus Rechberger <mrechberger@gmail.com>
To: Greg KH <greg@kroah.com>
Cc: werner@guyane.dyn-o-saur.com,
Linus Torvalds <torvalds@linux-foundation.org>,
Marcus Meissner <meissner@suse.de>,
linux-kernel@vger.kernel.org
Subject: Re: 2.6.33 bugs (USBFS, Intel graphic)
Date: Sat, 27 Feb 2010 05:05:41 +0100 [thread overview]
Message-ID: <d9def9db1002262005t6d63b902s673fb01dac228e4d@mail.gmail.com> (raw)
In-Reply-To: <20100227035639.GA11680@kroah.com>
On Sat, Feb 27, 2010 at 4:56 AM, Greg KH <greg@kroah.com> wrote:
> On Sat, Feb 27, 2010 at 04:42:53AM +0100, Markus Rechberger wrote:
>> * http://lkml.org/lkml/2010/2/19/192
>> .6.32-stable review patch. If anyone has any objections, please let us know.
>>
>> ------------------
>> From: Greg KH <greg@kroah.com>
>>
>> commit d4a4683ca054ed9917dfc9e3ff0f7ecf74ad90d6 upstream.
>>
>> We need to only copy the data received by the device to userspace, not
>> the whole kernel buffer, which can contain "stale" data.
>>
>> Thanks to Marcus Meissner for pointing this out and testing the fix.
>>
>> Reported-by: Marcus Meissner <meissner@suse.de>
>> Tested-by: Marcus Meissner <meissner@suse.de>
>> Cc: Alan Stern <stern@rowland.harvard.edu>
>> Cc: Linus Torvalds <torvalds@linux-foundation.org>
>> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
>>
>>
>> this patch breaks isochronous USBFS support, please revert that patch!
>>
>> http://sundtek.de/images/tvtime-bildfehler.jpg
>>
>> with the patch reverted:
>> http://sundtek.de/images/tvtime-working.png
>>
>> * Intel graphic flickers now
>
> That is very strange. What userspace program is using usbfs for video
> feeds? And why would it be relying on the invalid data on the end of an
> urb?
>
there are 2 userspace videowrapper available for linux and freebsd
which do videoprocessing in userland rather than in kernelspace.
Well isochronous works slightly different than BULK transfer (which I
guess was tested)
urb->iso_frame_desc[i].actual_length
each microframe has it's own length field for ISO.
Markus
next prev parent reply other threads:[~2010-02-27 4:05 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-27 3:42 Markus Rechberger
2010-02-27 3:56 ` Greg KH
2010-02-27 4:05 ` Markus Rechberger [this message]
2010-02-27 4:18 ` Greg KH
2010-02-27 4:29 ` Linus Torvalds
2010-02-27 4:34 ` Markus Rechberger
2010-02-27 5:17 ` Greg KH
2010-02-27 5:26 ` Greg KH
2010-02-27 5:38 ` Markus Rechberger
2010-02-27 5:48 ` Greg KH
2010-02-27 11:00 ` Markus Rechberger
2010-02-27 12:15 ` Pekka Enberg
2010-02-27 12:17 ` Pekka Enberg
2010-02-27 16:49 ` Jesse Barnes
2010-02-27 18:08 ` Markus Rechberger
2010-02-27 22:33 ` Markus Rechberger
2010-02-27 17:20 ` Alan Stern
2010-03-03 0:09 ` Greg KH
2010-03-05 21:37 ` Markus Rechberger
2010-03-06 16:30 ` Markus Rechberger
2010-03-06 17:06 ` Greg KH
2010-03-06 20:04 ` Alan Stern
2010-02-27 4:11 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d9def9db1002262005t6d63b902s673fb01dac228e4d@mail.gmail.com \
--to=mrechberger@gmail.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=meissner@suse.de \
--cc=torvalds@linux-foundation.org \
--cc=werner@guyane.dyn-o-saur.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome