From: Linus Torvalds <torvalds@linux-foundation.org>
To: Eric Paris <eparis@redhat.com>
Cc: viro@zeniv.linux.org.uk, hch@infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [GIT PULL] notification: including fanotify
Date: Sat, 27 Feb 2010 13:33:21 -0800 (PST) [thread overview]
Message-ID: <alpine.LFD.2.00.1002271331570.4513@localhost.localdomain> (raw)
In-Reply-To: <alpine.LFD.2.00.1002271323320.4513@localhost.localdomain>
On Sat, 27 Feb 2010, Linus Torvalds wrote:
>
> (b) the compile has obviously never been tested with any modern gcc
> version. I get tons of warnings after the pull, like
In fact, this seems to be due to a commit that explicitly says:
I do not add -Wpointer-sign to the fsnotify
code as there are still issues with kstrdup and strlen which would pop
out needless warnings.
but then the patch actually has
--- a/fs/notify/Makefile
+++ b/fs/notify/Makefile
@@ -1,3 +1,5 @@
+EXTRA_CFLAGS += -Wpointer-sign
+
WTF? Which part of this was tested AT ALL? Clearly there was not even a
compile test going on.
Linus
next prev parent reply other threads:[~2010-02-27 21:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-26 21:14 Eric Paris
2010-02-27 21:29 ` Linus Torvalds
2010-02-27 21:33 ` Linus Torvalds [this message]
2010-02-27 23:29 ` Stephen Rothwell
2010-02-27 23:38 ` Linus Torvalds
2010-02-27 22:51 ` Al Viro
2010-02-27 23:49 ` Eric Paris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.1002271331570.4513@localhost.localdomain \
--to=torvalds@linux-foundation.org \
--cc=eparis@redhat.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome