Re: [PATCH] base firmware: Fix BUG from sysfs attributes change in commit a2db6842873c8e5a70652f278d469128cb52db70

[Linus Torvalds <torvalds@linux-foundation.org>]

On Sun, 14 Mar 2010, Wolfram Sang wrote:
>
> coccinelle can apply semantic patches, rough description here [1]. So I wrote
> one which checks for every c-file in the kernel-tree:
>
> - Is there a structure containing (bin_)attribute?
> - Does a function declare a pointer to such a structure?
> - Is this pointer then used for a sysfs_create(_bin)_file?
> - If so, has there been a call to sysfs(_bin)_attr_init before?
>
> If not -> report. As coccinelle works on an abstract level of the code (not on
> source-code level), it can follow code-paths and such. Really nice tool, once
> you gathered the information to learn it.
> 
> The outcome are those patches:
> 
> http://patchwork.kernel.org/patch/85214/
>
> http://patchwork.kernel.org/patch/85212/
> (which is pretty much the same like the patch originating this thread. I vote
> very much for dropping those patches and use
> http://patchwork.kernel.org/patch/84814/ instead!)
> 
> http://patchwork.kernel.org/patch/85213/

Hey, goodie.  Can we merge the trivial one-liners into a single patch that 
fixes the issue?

Also, that "firmware_attr_data" thing should probably be marked 'const', 
no? That should make it more obvious that it's ok to share across multiple 
different firmware file, I think.

> Eric, if you have a bit of time, acking these patches would help them getting
> accepted for the mips/rtc-trees, IMHO.

You removed everybody from the Cc: line, so I doubt Eric even sees your 
email. I added the cc's back in.

			Linus