From: Linus Torvalds <torvalds@linux-foundation.org>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
Thomas Gleixner <tglx@linutronix.de>,
Al Viro <viro@ZenIV.linux.org.uk>, Jan Blunck <jblunck@suse.de>,
Ingo Molnar <mingo@elte.hu>, John Kacur <jkacur@redhat.com>
Subject: Re: [GIT PULL v2] Preparation for BKL'ed ioctl removal
Date: Sat, 24 Apr 2010 11:47:17 -0700 (PDT) [thread overview]
Message-ID: <alpine.LFD.2.00.1004241146520.3739@i5.linux-foundation.org> (raw)
In-Reply-To: <alpine.LFD.2.00.1004241135460.3739@i5.linux-foundation.org>
On Sat, 24 Apr 2010, Linus Torvalds wrote:
>
> I don't see the point, frankly. Especially not outside the merge window,
> but quite frankly, I don't see it in general. The whole thing seems to be
> designed to be inconvenient, and to have a config option that I
> fundamentally don't believe in (CONFIG_BKL).
More detail: it still leaves that old "ioctl" function pointer that needs
the BKL and is ungreppable. So the whole and only point of the patch is to
make our current mess even _more_ complex, with three different cases. No,
thank you.
Quite frankly, if you want to get rid of the BKL in ioctl's and make them
easily greppable, then I would suggest a simple renaming: rename the
current '->ioctl()' thing to '->bkl_ioctl()', and mark it deprecated. No
new config options, no new games. Just rename it. No need to mark things
with CONFIG_BKL, when you can just see it by virtue of them using
'bkl_ioctl'.
Linus
next prev parent reply other threads:[~2010-04-24 18:49 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-16 3:56 [GIT PULL] " Frederic Weisbecker
2010-04-22 0:48 ` [GIT PULL v2] " Frederic Weisbecker
2010-04-24 15:25 ` Frederic Weisbecker
2010-04-24 18:36 ` Linus Torvalds
2010-04-24 18:47 ` Linus Torvalds [this message]
2010-04-24 19:54 ` Arnd Bergmann
2010-04-24 20:01 ` Linus Torvalds
2010-04-24 20:40 ` Arnd Bergmann
2010-04-24 22:15 ` Linus Torvalds
2010-04-25 17:39 ` Frederic Weisbecker
2010-04-25 17:49 ` Linus Torvalds
2010-04-25 18:05 ` Frederic Weisbecker
2010-04-26 8:30 ` Arnd Bergmann
2010-04-26 18:08 ` Linus Torvalds
2010-04-26 19:12 ` Arnd Bergmann
2010-04-26 20:36 ` Linus Torvalds
2010-04-26 22:23 ` [PATCH 0/6] Push down BKL into device drivers Arnd Bergmann
2010-04-27 9:14 ` John Kacur
2010-04-26 22:24 ` [PATCH 1/6] dvb: push down BKL into ioctl functions Arnd Bergmann
2010-04-26 22:24 ` [PATCH 2/6] scsi: " Arnd Bergmann
2010-04-26 22:24 ` [PATCH 3/6] isdn: " Arnd Bergmann
2010-04-26 22:24 ` [PATCH 4/6] staging: " Arnd Bergmann
2010-04-27 18:15 ` Frederic Weisbecker
2010-04-27 18:33 ` Greg KH
2010-04-26 22:24 ` [PATCH 5/6] v4l: always use unlocked_ioctl Arnd Bergmann
2010-04-26 22:24 ` [PATCH 6/6] drivers: push down BKL into various drivers Arnd Bergmann
2010-04-26 20:42 ` [GIT PULL v2] Preparation for BKL'ed ioctl removal David Miller
2010-04-26 22:09 ` Frederic Weisbecker
2010-04-26 22:32 ` Linus Torvalds
2010-04-26 23:04 ` Frederic Weisbecker
2010-04-26 7:25 ` Ingo Molnar
2010-04-26 11:29 ` Arnd Bergmann
2010-04-27 9:25 ` Ingo Molnar
2010-04-28 13:21 ` Frederic Weisbecker
2010-04-28 13:37 ` Ingo Molnar
2010-04-28 14:05 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.1004241146520.3739@i5.linux-foundation.org \
--to=torvalds@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=fweisbec@gmail.com \
--cc=jblunck@suse.de \
--cc=jkacur@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®