From: Thomas Gleixner <tglx@linutronix.de>
To: Feng Tang <feng.tang@intel.com>
Cc: Ingo Molnar <mingo@elte.hu>, "H.Peter Anvin" <hpa@zytor.com>,
"Brown, Len" <len.brown@intel.com>,
LKML <linux-kernel@vger.kernel.org>,
"Pan, Jacob jun" <jacob.jun.pan@intel.com>,
Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: [PATCH] x86: unify current 3 similar ways of saving IRQ info
Date: Mon, 17 May 2010 10:07:05 +0200 (CEST) [thread overview]
Message-ID: <alpine.LFD.2.00.1005171004500.3368@localhost.localdomain> (raw)
In-Reply-To: <20100517153156.4439d62b@feng-i7>
On Mon, 17 May 2010, Feng Tang wrote:
>
> -static void __init assign_to_mp_irq(struct mpc_intsrc *m,
Why are you removing __init ?
> +static void assign_to_mp_irq(struct mpc_intsrc *m,
> struct mpc_intsrc *mp_irq)
> {
> mp_irq->dstapic = m->dstapic;
> @@ -190,7 +190,7 @@ static void __init assign_to_mpc_intsrc(struct mpc_intsrc *mp_irq,
> m->dstirq = mp_irq->dstirq;
> }
>
> -static int __init mp_irq_mpc_intsrc_cmp(struct mpc_intsrc *mp_irq,
> +static int mp_irq_mpc_intsrc_cmp(struct mpc_intsrc *mp_irq,
> struct mpc_intsrc *m)
Ditto
> {
> if (mp_irq->dstapic != m->dstapic)
> @@ -211,7 +211,8 @@ static int __init mp_irq_mpc_intsrc_cmp(struct mpc_intsrc *mp_irq,
> return 0;
> }
>
> -static void __init MP_intsrc_info(struct mpc_intsrc *m)
> +/* Will also be called in acpi/sfi related code */
> +void mp_save_irq(struct mpc_intsrc *m)
Again, this code is called from __init context only and should stay
__init.
Thanks,
tglx
next parent reply other threads:[~2010-05-17 8:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20100517153156.4439d62b@feng-i7>
2010-05-17 8:07 ` Thomas Gleixner [this message]
[not found] ` <20100517162521.6fc93552@feng-i7>
2010-05-17 8:16 ` Thomas Gleixner
[not found] ` <20100517164244.3fc80d60@feng-i7>
2010-05-17 9:00 ` Thomas Gleixner
2010-10-25 8:36 Feng Tang
2010-12-03 4:11 Feng Tang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.1005171004500.3368@localhost.localdomain \
--to=tglx@linutronix.de \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=feng.tang@intel.com \
--cc=hpa@zytor.com \
--cc=jacob.jun.pan@intel.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®