From: Linus Torvalds <torvalds@linux-foundation.org>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Heiko Carstens <heiko.carstens@de.ibm.com>,
linux-kernel@vger.kernel.org,
"arjan@infradead.org" <arjan@infradead.org>,
Andrew Morton <akpm@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] Documentation/timers/hpet_example.c: only build on X64
Date: Tue, 1 Jun 2010 08:55:19 -0700 (PDT) [thread overview]
Message-ID: <alpine.LFD.2.00.1006010852470.3637@i5.linux-foundation.org> (raw)
In-Reply-To: <4C0470BE.6040709@oracle.com>
On Mon, 31 May 2010, Randy Dunlap wrote:
>
> We should only build hpet_example on X64, where it is
> implemented. It can cause build errors on other arch-es.
Both the subject and the body say "X64" (don't use that, btw, it's x86-64,
please), but the patch itself says CONFIG_X86.
So what is it? Is it any x86, is it just 64-bit, or what?
So if it's any x86, then please say so in the explanation. And if it's
really just x86-64, then use CONFIG_X86_64 as the config variable (and
x86-64 rather than X64 in the commentary).
Linus
next prev parent reply other threads:[~2010-06-01 15:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-28 11:35 Documentation/timers/hpet_example.c compile bug Heiko Carstens
2010-05-29 18:41 ` Randy Dunlap
2010-05-31 2:34 ` Randy Dunlap
2010-05-31 2:49 ` Arjan van de Ven
2010-05-31 2:58 ` Randy Dunlap
2010-05-31 3:10 ` Arjan van de Ven
2010-06-01 2:30 ` [PATCH] Documentation/timers/hpet_example.c: only build on X64 Randy Dunlap
2010-06-01 15:55 ` Linus Torvalds [this message]
2010-06-01 16:55 ` [PATCH v2] Documentation/timers/hpet_example.c: only build on X86 Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.1006010852470.3637@i5.linux-foundation.org \
--to=torvalds@linux-foundation.org \
--cc=akpm@linux-foundation.org \
--cc=arjan@infradead.org \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome