From: Thomas Gleixner <tglx@linutronix.de>
To: Grazvydas Ignotas <notasas@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>, linux-kernel@vger.kernel.org
Subject: Re: twl4030 irq crashes
Date: Thu, 7 Oct 2010 20:37:31 +0200 (CEST) [thread overview]
Message-ID: <alpine.LFD.2.00.1010072037010.2501@localhost6.localdomain6> (raw)
In-Reply-To: <AANLkTik++Rb-x+aLtKv83USqSn8tQ4iyfSyWCNgfM+nO@mail.gmail.com>
[-- Attachment #1: Type: TEXT/PLAIN, Size: 1567 bytes --]
On Thu, 7 Oct 2010, Grazvydas Ignotas wrote:
> On Thu, Oct 7, 2010 at 1:59 AM, Thomas Gleixner <tglx@linutronix.de> wrote:
> > On Thu, 7 Oct 2010, Grazvydas Ignotas wrote:
> >
> >> Hello,
> >>
> >> I've pulled today's (20101006) linux-next and twl4030 started crashing
> >> on certain interrupts. twl4030 irq code hasn't changed so it's
> >> probably genirq's fault:
> >>
> >> [ 0.889739] Unable to handle kernel NULL pointer dereference at
> >> virtual address 00000000
> >> [ 0.898193] pgd = c0004000
> >> [ 0.901000] [00000000] *pgd=00000000
> >> [ 0.904754] Internal error: Oops: 80000005 [#1]
> >> [ 0.909484] last sysfs file:
> >> [ 0.912567] Modules linked in:
> >> [ 0.915771] CPU: 0 Not tainted
> >> (2.6.36-rc6-next-20101006-00001-g766a681-dirty #205)
> >> [ 0.924133] PC is at 0x0
> >> [ 0.926788] LR is at handle_edge_irq+0x84/0x14c
> >
> > Can you please decode that line with
> >
> > addr2line -e vmlinux c0077244
>
> kernel/irq/chip.c:725
The patch below should cure that.
Thanks,
tglx
---
diff --git a/drivers/mfd/twl4030-irq.c b/drivers/mfd/twl4030-irq.c
index 61c8664..b9fda70 100644
--- a/drivers/mfd/twl4030-irq.c
+++ b/drivers/mfd/twl4030-irq.c
@@ -810,7 +810,7 @@ int twl4030_init_irq(int irq_num, unsigned irq_base, unsigned irq_end)
twl4030_irq_chip = dummy_irq_chip;
twl4030_irq_chip.name = "twl4030";
- twl4030_sih_irq_chip.ack = dummy_irq_chip.ack;
+ twl4030_sih_irq_chip.irq_ack = dummy_irq_chip.irq_ack;
for (i = irq_base; i < irq_end; i++) {
set_irq_chip_and_handler(i, &twl4030_irq_chip,
next prev parent reply other threads:[~2010-10-07 18:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-06 22:29 Grazvydas Ignotas
2010-10-06 22:59 ` Thomas Gleixner
2010-10-06 23:27 ` Grazvydas Ignotas
2010-10-07 18:37 ` Thomas Gleixner [this message]
2010-10-07 22:40 ` Grazvydas Ignotas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.1010072037010.2501@localhost6.localdomain6 \
--to=tglx@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=notasas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®