* twl4030 irq crashes
@ 2010-10-06 22:29 Grazvydas Ignotas
2010-10-06 22:59 ` Thomas Gleixner
0 siblings, 1 reply; 5+ messages in thread
From: Grazvydas Ignotas @ 2010-10-06 22:29 UTC (permalink / raw)
To: Thomas Gleixner; +Cc: Ingo Molnar, linux-kernel
Hello,
I've pulled today's (20101006) linux-next and twl4030 started crashing
on certain interrupts. twl4030 irq code hasn't changed so it's
probably genirq's fault:
[ 0.889739] Unable to handle kernel NULL pointer dereference at
virtual address 00000000
[ 0.898193] pgd = c0004000
[ 0.901000] [00000000] *pgd=00000000
[ 0.904754] Internal error: Oops: 80000005 [#1]
[ 0.909484] last sysfs file:
[ 0.912567] Modules linked in:
[ 0.915771] CPU: 0 Not tainted
(2.6.36-rc6-next-20101006-00001-g766a681-dirty #205)
[ 0.924133] PC is at 0x0
[ 0.926788] LR is at handle_edge_irq+0x84/0x14c
[ 0.931518] pc : [<00000000>] lr : [<c0077244>] psr: a0000093
[ 0.931549] sp : cf8a5f80 ip : 00000000 fp : 00000000
[ 0.943511] r10: 00000000 r9 : 00000000 r8 : cf897f80
[ 0.948974] r7 : c0230d6c r6 : 0000017a r5 : 00000004 r4 : c03060c8
[ 0.955810] r3 : c030d530 r2 : c031d36c r1 : 00020003 r0 : c03060c8
[ 0.962615] Flags: NzCv IRQs off FIQs on Mode SVC_32 ISA ARM
Segment kernel
[ 0.970336] Control: 10c5387d Table: 80004019 DAC: 00000015
[ 0.976348] Process twl4030-irq (pid: 137, stack limit = 0xcf8a42f0)
[ 0.982971] Stack: (0xcf8a5f80 to 0xcf8a6000)
[ 0.987548] 5f80: 0000017a 00000004 00000002 c015779c 00000175
00000004 00000175 00000000
[ 0.996093] 5fa0: 00000007 c015759c 00000000 c0157690 00000007
013071d0 cf8a5fd4 cf81bd20
[ 1.004638] 5fc0: 00000007 c006155c c0030078 00000000 00000007
00000000 cf8a5fd8 cf8a5fd8
[ 1.013183] 5fe0: 00000000 cf81bd20 c00614d8 c0030078 00000013
c0030078 00000000 00000000
[ 1.021759] [<c0077244>] (handle_edge_irq+0x84/0x14c) from
[<c015779c>] (handle_twl4030_sih+0xa0/0xd4)
[ 1.031494] [<c015779c>] (handle_twl4030_sih+0xa0/0xd4) from
[<c0157690>] (twl4030_irq_thread+0xf4/0x144)
[ 1.041503] [<c0157690>] (twl4030_irq_thread+0xf4/0x144) from
[<c006155c>] (kthread+0x84/0x8c)
[ 1.050537] [<c006155c>] (kthread+0x84/0x8c) from [<c0030078>]
(kernel_thread_exit+0x0/0x8)
[ 1.059265] Code: bad PC value
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: twl4030 irq crashes
2010-10-06 22:29 twl4030 irq crashes Grazvydas Ignotas
@ 2010-10-06 22:59 ` Thomas Gleixner
2010-10-06 23:27 ` Grazvydas Ignotas
0 siblings, 1 reply; 5+ messages in thread
From: Thomas Gleixner @ 2010-10-06 22:59 UTC (permalink / raw)
To: Grazvydas Ignotas; +Cc: Ingo Molnar, linux-kernel
On Thu, 7 Oct 2010, Grazvydas Ignotas wrote:
> Hello,
>
> I've pulled today's (20101006) linux-next and twl4030 started crashing
> on certain interrupts. twl4030 irq code hasn't changed so it's
> probably genirq's fault:
>
> [ 0.889739] Unable to handle kernel NULL pointer dereference at
> virtual address 00000000
> [ 0.898193] pgd = c0004000
> [ 0.901000] [00000000] *pgd=00000000
> [ 0.904754] Internal error: Oops: 80000005 [#1]
> [ 0.909484] last sysfs file:
> [ 0.912567] Modules linked in:
> [ 0.915771] CPU: 0 Not tainted
> (2.6.36-rc6-next-20101006-00001-g766a681-dirty #205)
> [ 0.924133] PC is at 0x0
> [ 0.926788] LR is at handle_edge_irq+0x84/0x14c
Can you please decode that line with
addr2line -e vmlinux c0077244
Thanks,
tglx
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: twl4030 irq crashes
2010-10-06 22:59 ` Thomas Gleixner
@ 2010-10-06 23:27 ` Grazvydas Ignotas
2010-10-07 18:37 ` Thomas Gleixner
0 siblings, 1 reply; 5+ messages in thread
From: Grazvydas Ignotas @ 2010-10-06 23:27 UTC (permalink / raw)
To: Thomas Gleixner; +Cc: Ingo Molnar, linux-kernel
On Thu, Oct 7, 2010 at 1:59 AM, Thomas Gleixner <tglx@linutronix.de> wrote:
> On Thu, 7 Oct 2010, Grazvydas Ignotas wrote:
>
>> Hello,
>>
>> I've pulled today's (20101006) linux-next and twl4030 started crashing
>> on certain interrupts. twl4030 irq code hasn't changed so it's
>> probably genirq's fault:
>>
>> [ 0.889739] Unable to handle kernel NULL pointer dereference at
>> virtual address 00000000
>> [ 0.898193] pgd = c0004000
>> [ 0.901000] [00000000] *pgd=00000000
>> [ 0.904754] Internal error: Oops: 80000005 [#1]
>> [ 0.909484] last sysfs file:
>> [ 0.912567] Modules linked in:
>> [ 0.915771] CPU: 0 Not tainted
>> (2.6.36-rc6-next-20101006-00001-g766a681-dirty #205)
>> [ 0.924133] PC is at 0x0
>> [ 0.926788] LR is at handle_edge_irq+0x84/0x14c
>
> Can you please decode that line with
>
> addr2line -e vmlinux c0077244
kernel/irq/chip.c:725
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: twl4030 irq crashes
2010-10-06 23:27 ` Grazvydas Ignotas
@ 2010-10-07 18:37 ` Thomas Gleixner
2010-10-07 22:40 ` Grazvydas Ignotas
0 siblings, 1 reply; 5+ messages in thread
From: Thomas Gleixner @ 2010-10-07 18:37 UTC (permalink / raw)
To: Grazvydas Ignotas; +Cc: Ingo Molnar, linux-kernel
[-- Attachment #1: Type: TEXT/PLAIN, Size: 1567 bytes --]
On Thu, 7 Oct 2010, Grazvydas Ignotas wrote:
> On Thu, Oct 7, 2010 at 1:59 AM, Thomas Gleixner <tglx@linutronix.de> wrote:
> > On Thu, 7 Oct 2010, Grazvydas Ignotas wrote:
> >
> >> Hello,
> >>
> >> I've pulled today's (20101006) linux-next and twl4030 started crashing
> >> on certain interrupts. twl4030 irq code hasn't changed so it's
> >> probably genirq's fault:
> >>
> >> [ 0.889739] Unable to handle kernel NULL pointer dereference at
> >> virtual address 00000000
> >> [ 0.898193] pgd = c0004000
> >> [ 0.901000] [00000000] *pgd=00000000
> >> [ 0.904754] Internal error: Oops: 80000005 [#1]
> >> [ 0.909484] last sysfs file:
> >> [ 0.912567] Modules linked in:
> >> [ 0.915771] CPU: 0 Not tainted
> >> (2.6.36-rc6-next-20101006-00001-g766a681-dirty #205)
> >> [ 0.924133] PC is at 0x0
> >> [ 0.926788] LR is at handle_edge_irq+0x84/0x14c
> >
> > Can you please decode that line with
> >
> > addr2line -e vmlinux c0077244
>
> kernel/irq/chip.c:725
The patch below should cure that.
Thanks,
tglx
---
diff --git a/drivers/mfd/twl4030-irq.c b/drivers/mfd/twl4030-irq.c
index 61c8664..b9fda70 100644
--- a/drivers/mfd/twl4030-irq.c
+++ b/drivers/mfd/twl4030-irq.c
@@ -810,7 +810,7 @@ int twl4030_init_irq(int irq_num, unsigned irq_base, unsigned irq_end)
twl4030_irq_chip = dummy_irq_chip;
twl4030_irq_chip.name = "twl4030";
- twl4030_sih_irq_chip.ack = dummy_irq_chip.ack;
+ twl4030_sih_irq_chip.irq_ack = dummy_irq_chip.irq_ack;
for (i = irq_base; i < irq_end; i++) {
set_irq_chip_and_handler(i, &twl4030_irq_chip,
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: twl4030 irq crashes
2010-10-07 18:37 ` Thomas Gleixner
@ 2010-10-07 22:40 ` Grazvydas Ignotas
0 siblings, 0 replies; 5+ messages in thread
From: Grazvydas Ignotas @ 2010-10-07 22:40 UTC (permalink / raw)
To: Thomas Gleixner; +Cc: Ingo Molnar, linux-kernel
On Thu, Oct 7, 2010 at 9:37 PM, Thomas Gleixner <tglx@linutronix.de> wrote:
> On Thu, 7 Oct 2010, Grazvydas Ignotas wrote:
>> On Thu, Oct 7, 2010 at 1:59 AM, Thomas Gleixner <tglx@linutronix.de> wrote:
>> > On Thu, 7 Oct 2010, Grazvydas Ignotas wrote:
>> >
>> >> Hello,
>> >>
>> >> I've pulled today's (20101006) linux-next and twl4030 started crashing
>> >> on certain interrupts. twl4030 irq code hasn't changed so it's
>> >> probably genirq's fault:
>> >>
>> >> [ 0.889739] Unable to handle kernel NULL pointer dereference at
>> >> virtual address 00000000
>> >> [ 0.898193] pgd = c0004000
>> >> [ 0.901000] [00000000] *pgd=00000000
>> >> [ 0.904754] Internal error: Oops: 80000005 [#1]
>> >> [ 0.909484] last sysfs file:
>> >> [ 0.912567] Modules linked in:
>> >> [ 0.915771] CPU: 0 Not tainted
>> >> (2.6.36-rc6-next-20101006-00001-g766a681-dirty #205)
>> >> [ 0.924133] PC is at 0x0
>> >> [ 0.926788] LR is at handle_edge_irq+0x84/0x14c
>> >
>> > Can you please decode that line with
>> >
>> > addr2line -e vmlinux c0077244
>>
>> kernel/irq/chip.c:725
>
> The patch below should cure that.
Yup, it indeed does.
Tested-by: Grazvydas Ignotas <notasas@gmail.com>
>
> Thanks,
>
> tglx
> ---
> diff --git a/drivers/mfd/twl4030-irq.c b/drivers/mfd/twl4030-irq.c
> index 61c8664..b9fda70 100644
> --- a/drivers/mfd/twl4030-irq.c
> +++ b/drivers/mfd/twl4030-irq.c
> @@ -810,7 +810,7 @@ int twl4030_init_irq(int irq_num, unsigned irq_base, unsigned irq_end)
> twl4030_irq_chip = dummy_irq_chip;
> twl4030_irq_chip.name = "twl4030";
>
> - twl4030_sih_irq_chip.ack = dummy_irq_chip.ack;
> + twl4030_sih_irq_chip.irq_ack = dummy_irq_chip.irq_ack;
>
> for (i = irq_base; i < irq_end; i++) {
> set_irq_chip_and_handler(i, &twl4030_irq_chip,
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2010-10-07 22:40 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-10-06 22:29 twl4030 irq crashes Grazvydas Ignotas
2010-10-06 22:59 ` Thomas Gleixner
2010-10-06 23:27 ` Grazvydas Ignotas
2010-10-07 18:37 ` Thomas Gleixner
2010-10-07 22:40 ` Grazvydas Ignotas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®