From: Thomas Gleixner <tglx@linutronix.de>
To: Peter Zijlstra <peterz@infradead.org>
Cc: mingo@redhat.com, hpa@zytor.com, linux-kernel@vger.kernel.org,
sqazi@google.com, linux-tip-commits@vger.kernel.org
Subject: Re: [tip:timers/urgent] hrtimer: Preserve timer state in remove_hrtimer()
Date: Thu, 14 Oct 2010 15:34:43 +0200 (CEST) [thread overview]
Message-ID: <alpine.LFD.2.00.1010141530360.2655@localhost6.localdomain6> (raw)
In-Reply-To: <1287062583.29097.194.camel@twins>
On Thu, 14 Oct 2010, Peter Zijlstra wrote:
> On Thu, 2010-10-14 at 11:34 +0000, tip-bot for Salman Qazi wrote:
> > The bug was introduced with commit ca109491f (hrtimer: removing all ur
> > callback modes) in 2.6.29
>
> Not actually sure about that,. afaict its due to unlocking the base lock
> over the callback, which comes from 2d44ae4d7 (hrtimer: clean up
> cpu->base locking tricks), and existed before that in the special case
> of the scheduler tick (for which this problem is very unlikely to have
> ever triggered because we simply don't call start on it when its
> running).
Yeah, I got confused on that :)
> Anyway, the patch does look good, so
tglx
next prev parent reply other threads:[~2010-10-14 13:35 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-08 2:33 [PATCH] Fix a complex race in hrtimer code Salman Qazi
2010-10-08 18:01 ` Salman Qazi
2010-10-11 22:43 ` Andrew Morton
2010-10-11 23:18 ` Salman Qazi
2010-10-11 23:23 ` Andrew Morton
2010-10-11 23:43 ` Salman Qazi
2010-10-12 0:02 ` Salman Qazi
2010-10-12 8:49 ` Thomas Gleixner
2010-10-12 14:25 ` Salman Qazi
2010-10-14 11:34 ` [tip:timers/urgent] hrtimer: Preserve timer state in remove_hrtimer() tip-bot for Salman Qazi
2010-10-14 13:23 ` Peter Zijlstra
2010-10-14 13:34 ` Thomas Gleixner [this message]
2010-10-12 14:28 ` [PATCH] Fix a complex race in hrtimer code Salman Qazi
2010-10-12 16:54 ` Thomas Gleixner
2010-10-12 17:38 ` Salman Qazi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.1010141530360.2655@localhost6.localdomain6 \
--to=tglx@linutronix.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=sqazi@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®