From: Thomas Gleixner <tglx@linutronix.de>
To: Torben Hohn <torbenh@gmx.de>
Cc: linux-kernel@vger.kernel.org, johnstul@us.ibm.com,
hch@infradead.org, yong.zhang0@gmail.com
Subject: Re: [PATCH 09/18] frv: switch do_timer() to xtime_update()
Date: Sat, 22 Jan 2011 11:01:49 +0100 (CET) [thread overview]
Message-ID: <alpine.LFD.2.00.1101221051570.2971@localhost6.localdomain6> (raw)
In-Reply-To: <1295651224-29823-10-git-send-email-torbenh@gmx.de>
On Sat, 22 Jan 2011, Torben Hohn wrote:
> this code looks like its protecting __set_LEDS() with this lock also.
> i dont think thats necessary.
This changelog is horrible.
This code does not look like protecting the __set_LEDS() call with the
xtime_lock. The call happens to be inside the xtime_lock held region.
Now instead of bringing up a weak argument "I dont think ..." you
should provide a proper analysis why it's safe to move that code out.
It's pretty simple:
No other call site of __set_LEDS() is protected by xtime_lock, so
xtime_lock does not protect anything related to __set_LEDS(). It's
just inside the xtime_lock region for no good reason at all.
Please be more careful when writing change logs, so a reviewer can
understand the reasoning behind your change easily.
Also all arch/* patches are missing a "Cc: arch-maintainer@somewhere.xxx".
> {
> @@ -61,10 +61,11 @@ static irqreturn_t timer_interrupt(int irq, void *dummy)
> * CPU. We need to avoid to SMP race with it. NOTE: we don't need
> * the irq version of write_lock because as just said we have irq
> * locally disabled. -arca
> + *
> + * xtime_update takes the writelock.
Errm. xtime_update write locks xtime_lock. Please be careful with comments.
Thanks,
tglx
next prev parent reply other threads:[~2011-01-22 10:04 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-21 23:06 make arch code use xtime_update() instead of do_timer() Torben Hohn
2011-01-21 23:06 ` [PATCH 01/18] move do_timer() from kernel/timer.c into kernel/time/timekeeping.c Torben Hohn
2011-01-22 9:45 ` Thomas Gleixner
2011-01-24 20:32 ` john stultz
2011-01-24 22:10 ` Thomas Gleixner
2011-01-24 22:21 ` Peter Zijlstra
2011-01-24 22:44 ` Thomas Gleixner
2011-01-25 9:08 ` Peter Zijlstra
2011-01-25 10:34 ` Peter Zijlstra
2011-01-25 16:51 ` Peter Zijlstra
2011-01-26 5:56 ` Yong Zhang
2011-01-26 6:49 ` Yong Zhang
2011-01-26 10:03 ` Peter Zijlstra
2011-01-26 11:11 ` Yong Zhang
2011-01-21 23:06 ` [PATCH 02/18] provide xtime_update() which does not require holding xtime_lock like do_timer() Torben Hohn
2011-01-22 10:36 ` Thomas Gleixner
2011-01-21 23:06 ` [PATCH 03/18] alpha: change do_timer() to xtime_update() Torben Hohn
2011-01-21 23:06 ` [PATCH 04/18] arm: switch from " Torben Hohn
2011-01-21 23:06 ` [PATCH 05/18] arm/mach-clps711x: switch " Torben Hohn
2011-01-21 23:06 ` [PATCH 06/18] blackfin: switch from " Torben Hohn
2011-01-21 23:06 ` [PATCH 07/18] cris/arch-v10: switch " Torben Hohn
2011-01-21 23:06 ` [PATCH 08/18] cris/arch-v32: " Torben Hohn
2011-01-21 23:06 ` [PATCH 09/18] frv: " Torben Hohn
2011-01-22 10:01 ` Thomas Gleixner [this message]
2011-01-24 12:51 ` torbenh
2011-01-24 13:09 ` Thomas Gleixner
2011-01-21 23:06 ` [PATCH 10/18] h8300: " Torben Hohn
2011-01-21 23:06 ` [PATCH 11/18] ia64: " Torben Hohn
2011-01-21 23:06 ` [PATCH 12/18] m32r: switch from " Torben Hohn
2011-01-21 23:06 ` [PATCH 13/18] m68k: switch " Torben Hohn
2011-01-21 23:07 ` [PATCH 14/18] mn10300: switch do_timer() to xtimer_update() Torben Hohn
2011-01-21 23:07 ` [PATCH 15/18] parisc: switch do_timer() to xtime_update() Torben Hohn
2011-01-21 23:07 ` [PATCH 16/18] sparc: " Torben Hohn
2011-01-22 0:51 ` David Miller
2011-01-21 23:07 ` [PATCH 17/18] xtensa: " Torben Hohn
2011-01-21 23:07 ` [PATCH 18/18] make do_timer() and xtime_lock private to the timer code Torben Hohn
2011-01-22 10:14 ` make arch code use xtime_update() instead of do_timer() Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.1101221051570.2971@localhost6.localdomain6 \
--to=tglx@linutronix.de \
--cc=hch@infradead.org \
--cc=johnstul@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torbenh@gmx.de \
--cc=yong.zhang0@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®