From: Julian Anastasov <ja@ssi.bg>
To: Sasha Levin <levinsasha928@gmail.com>
Cc: wensong@linux-vs.org, horms@verge.net.au, kaber@trash.net,
davem@davemloft.net, davej@redhat.com, netdev@vger.kernel.org,
lvs-devel@vger.kernel.org, netfilter-devel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] netfilter: ipvs: Verify that IP_VS protocol has been registered
Date: Sat, 14 Apr 2012 15:23:32 +0300 (EEST) [thread overview]
Message-ID: <alpine.LFD.2.00.1204141518270.9966@ja.ssi.bg> (raw)
In-Reply-To: <CA+1xoqe0q=XH7mO6=qZKPxqZK8LU2Kk5BjmfLeQ9LUD1Ku65YA@mail.gmail.com>
[-- Attachment #1: Type: TEXT/PLAIN, Size: 1021 bytes --]
Hello,
On Sat, 14 Apr 2012, Sasha Levin wrote:
> On Sat, Apr 14, 2012 at 1:53 PM, Julian Anastasov <ja@ssi.bg> wrote:
> > Ops. It seems now we expose old problem when
> > no protocol is configured. As this change probably will
> > go to stable kernels, lets make it correct. Can you
> > remove the defines around register_ip_vs_proto_netns, so
> > that it is always compiled. One that wants to save
> > memory will not disable all protocols. See commit
> > 091bb34c143674d37a59b2d4857534f7106c5d7d for reference.
>
> Oh, so it wasn't getting built right now at all if we didn't select
> any protocols.
>
> How about moving those defines down to our loop as well? this way
> everything will behave exactly like it did before.
Better to remove the defines. It is a misconfiguration
to enable IPVS without protocols. The referenced commit
just tried to remove warnings, not save memory by commenting
unused function. Adding more define makes the things more ugly.
Regards
--
Julian Anastasov <ja@ssi.bg>
next prev parent reply other threads:[~2012-04-14 12:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-14 13:22 Sasha Levin
2012-04-14 11:53 ` Julian Anastasov
2012-04-14 12:06 ` Sasha Levin
2012-04-14 12:23 ` Julian Anastasov [this message]
2012-04-14 12:32 ` Sasha Levin
2012-04-14 13:22 ` [PATCH v2 2/2] netfilter: ipvs: use GFP_KERNEL allocation where possible Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.1204141518270.9966@ja.ssi.bg \
--to=ja@ssi.bg \
--cc=davej@redhat.com \
--cc=davem@davemloft.net \
--cc=horms@verge.net.au \
--cc=kaber@trash.net \
--cc=levinsasha928@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lvs-devel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=wensong@linux-vs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®