mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* kmemleak: Pull request
@ 2009-06-11 16:25 Catalin Marinas
  2009-06-11 21:21 ` Linus Torvalds
  0 siblings, 1 reply; 6+ messages in thread
From: Catalin Marinas @ 2009-06-11 16:25 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: linux-kernel

Linus,

Please consider pulling the kmemleak patches from the branch detailed
below.

These patches have been posted/reviewed on several occasions on LKML and
available in the linux-next tree for about two kernel release cycles.
The necessary x86-specific patch is merged via the x86 tree and the
ARM-specific one via RMK's tree (these only add some vmlinux.lds.S
symbols).

Thanks.


The following changes since commit 991ec02cdca33b03a132a0cacfe6f0aa0be9aa8d:
  Linus Torvalds (1):
        Merge branch 'tracing-urgent-for-linus' of git://git.kernel.org/.../tip/linux-2.6-tip

are available in the git repository at:

  git://linux-arm.org/linux-2.6.git for-linus

Catalin Marinas (12):
      kmemleak: Add the base support
      kmemleak: Add documentation on the memory leak detector
      kmemleak: Add the slab memory allocation/freeing hooks
      kmemleak: Add the slob memory allocation/freeing hooks
      kmemleak: Add the slub memory allocation/freeing hooks
      kmemleak: Add the vmalloc memory allocation/freeing hooks
      kmemleak: Add kmemleak_alloc callback from alloc_large_system_hash
      kmemleak: Add modules support
      kmemleak: Remove some of the kmemleak false positives
      kmemleak: Enable the building of the memory leak detector
      kmemleak: Simple testing module for kmemleak
      kmemleak: Add the corresponding MAINTAINERS entry

 Documentation/kernel-parameters.txt |    4 +
 Documentation/kmemleak.txt          |  142 ++++
 MAINTAINERS                         |    6 +
 drivers/char/vt.c                   |    7 +
 fs/block_dev.c                      |    6 +
 include/linux/kmemleak.h            |   96 +++
 include/linux/percpu.h              |    5 +
 include/linux/slab.h                |    2 +
 init/main.c                         |    4 +-
 kernel/module.c                     |   56 ++
 lib/Kconfig.debug                   |   32 +
 mm/Makefile                         |    2 +
 mm/kmemleak-test.c                  |  111 +++
 mm/kmemleak.c                       | 1498 +++++++++++++++++++++++++++++++++++
 mm/page_alloc.c                     |   11 +
 mm/slab.c                           |   32 +-
 mm/slob.c                           |    7 +
 mm/slub.c                           |    5 +-
 mm/vmalloc.c                        |   30 +-
 19 files changed, 2049 insertions(+), 7 deletions(-)
 create mode 100644 Documentation/kmemleak.txt
 create mode 100644 include/linux/kmemleak.h
 create mode 100644 mm/kmemleak-test.c
 create mode 100644 mm/kmemleak.c

-- 
Catalin


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: kmemleak: Pull request
  2009-06-11 16:25 kmemleak: Pull request Catalin Marinas
@ 2009-06-11 21:21 ` Linus Torvalds
  2009-06-12  9:53   ` Catalin Marinas
  0 siblings, 1 reply; 6+ messages in thread
From: Linus Torvalds @ 2009-06-11 21:21 UTC (permalink / raw)
  To: Catalin Marinas; +Cc: linux-kernel



On Thu, 11 Jun 2009, Catalin Marinas wrote:
> 
> Please consider pulling the kmemleak patches from the branch detailed
> below.

Ok, I got conflicts with the slab/earlyboot changes, but they looked 
resolvable. I haven't tested the merge though, so please do give it a good 
check.

		Linus

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: kmemleak: Pull request
  2009-06-11 21:21 ` Linus Torvalds
@ 2009-06-12  9:53   ` Catalin Marinas
  2009-06-12  9:55     ` [PATCH 1/2] kmemleak: Remove the kmemleak.h include in drivers/char/vt.c Catalin Marinas
  2009-06-12  9:55     ` [PATCH 2/2] kmemleak: Add more info to the MAINTAINERS entry Catalin Marinas
  0 siblings, 2 replies; 6+ messages in thread
From: Catalin Marinas @ 2009-06-12  9:53 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: linux-kernel

On Thu, 2009-06-11 at 14:21 -0700, Linus Torvalds wrote:
> 
> On Thu, 11 Jun 2009, Catalin Marinas wrote:
> > 
> > Please consider pulling the kmemleak patches from the branch detailed
> > below.
> 
> Ok, I got conflicts with the slab/earlyboot changes, but they looked 
> resolvable. I haven't tested the merge though, so please do give it a good 
> check.

I tested it with both slab and slub allocators and seems alright (and
found a possible leak in tty_ldisc.c). I'll give it a try with slob as
well.

There are two more trivial patches to merge. I'll send them as replies
to this mail but you can pull them directly from the same for-linus
branch:


The following changes since commit 8ebf975608aaebd7feb33d77f07ba21a6380e086:
  Randy Dunlap (1):
        block: fix kernel-doc in recent block/ changes

are available in the git repository at:

  git://linux-arm.org/linux-2.6.git for-linus

Catalin Marinas (2):
      kmemleak: Remove the kmemleak.h include in drivers/char/vt.c
      kmemleak: Add more info to the MAINTAINERS entry

 MAINTAINERS       |   16 ++++++++++------
 drivers/char/vt.c |    1 -
 2 files changed, 10 insertions(+), 7 deletions(-)


Thanks.

-- 
Catalin


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH 1/2] kmemleak: Remove the kmemleak.h include in drivers/char/vt.c
  2009-06-12  9:53   ` Catalin Marinas
@ 2009-06-12  9:55     ` Catalin Marinas
  2009-06-12 12:07       ` Alan Cox
  2009-06-12  9:55     ` [PATCH 2/2] kmemleak: Add more info to the MAINTAINERS entry Catalin Marinas
  1 sibling, 1 reply; 6+ messages in thread
From: Catalin Marinas @ 2009-06-12  9:55 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: linux-kernel

This file is no longer annotated for false positives but the kmemleak.h
include was still present.

Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
---
 drivers/char/vt.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/drivers/char/vt.c b/drivers/char/vt.c
index de9ebee..c796a86 100644
--- a/drivers/char/vt.c
+++ b/drivers/char/vt.c
@@ -103,7 +103,6 @@
 #include <linux/io.h>
 #include <asm/system.h>
 #include <linux/uaccess.h>
-#include <linux/kmemleak.h>
 
 #define MAX_NR_CON_DRIVER 16
 


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH 2/2] kmemleak: Add more info to the MAINTAINERS entry
  2009-06-12  9:53   ` Catalin Marinas
  2009-06-12  9:55     ` [PATCH 1/2] kmemleak: Remove the kmemleak.h include in drivers/char/vt.c Catalin Marinas
@ 2009-06-12  9:55     ` Catalin Marinas
  1 sibling, 0 replies; 6+ messages in thread
From: Catalin Marinas @ 2009-06-12  9:55 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: linux-kernel

The patch adds the "F:" fields to the KMEMLEAK MAINTAINERS entry and
also moves it before KMEMTRACE to preserve the alphabetical order.

Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
---
 MAINTAINERS |   16 ++++++++++------
 1 files changed, 10 insertions(+), 6 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index c944d61..f7d64fa 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -3363,6 +3363,16 @@ F:	drivers/serial/kgdboc.c
 F:	include/linux/kgdb.h
 F:	kernel/kgdb.c
 
+KMEMLEAK
+P:	Catalin Marinas
+M:	catalin.marinas@arm.com
+L:	linux-kernel@vger.kernel.org
+S:	Maintained
+F:	Documentation/kmemleak.txt
+F:	include/linux/kmemleak.h
+F:	mm/kmemleak.c
+F:	mm/kmemleak-test.c
+
 KMEMTRACE
 P:	Eduard - Gabriel Munteanu
 M:	eduard.munteanu@linux360.ro
@@ -3372,12 +3382,6 @@ F:	Documentation/trace/kmemtrace.txt
 F:	include/trace/kmemtrace.h
 F:	kernel/trace/kmemtrace.c
 
-KMEMLEAK
-P:	Catalin Marinas
-M:	catalin.marinas@arm.com
-L:	linux-kernel@vger.kernel.org
-S:	Maintained
-
 KPROBES
 P:	Ananth N Mavinakayanahalli
 M:	ananth@in.ibm.com


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/2] kmemleak: Remove the kmemleak.h include in drivers/char/vt.c
  2009-06-12  9:55     ` [PATCH 1/2] kmemleak: Remove the kmemleak.h include in drivers/char/vt.c Catalin Marinas
@ 2009-06-12 12:07       ` Alan Cox
  0 siblings, 0 replies; 6+ messages in thread
From: Alan Cox @ 2009-06-12 12:07 UTC (permalink / raw)
  To: Catalin Marinas; +Cc: Linus Torvalds, linux-kernel

On Fri, 12 Jun 2009 10:55:44 +0100
Catalin Marinas <catalin.marinas@arm.com> wrote:

> This file is no longer annotated for false positives but the kmemleak.h
> include was still present.
> 
> Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>

Acked-by: Alan Cox <alan.cox@linux.intel.com>

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2009-06-12 12:07 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-06-11 16:25 kmemleak: Pull request Catalin Marinas
2009-06-11 21:21 ` Linus Torvalds
2009-06-12  9:53   ` Catalin Marinas
2009-06-12  9:55     ` [PATCH 1/2] kmemleak: Remove the kmemleak.h include in drivers/char/vt.c Catalin Marinas
2009-06-12 12:07       ` Alan Cox
2009-06-12  9:55     ` [PATCH 2/2] kmemleak: Add more info to the MAINTAINERS entry Catalin Marinas

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®