From: Linus Torvalds <torvalds@linux-foundation.org>
To: Eric Paris <eparis@redhat.com>
Cc: Frans Pop <elendil@planet.nl>,
linux-kernel@vger.kernel.org, linux-fs-devel@vger.kernel.org,
zdenek.kabelac@gmail.com, christoph.thielecke@gmx.de,
akpm@linux-foundation.org, viro@zeniv.linux.org.uk,
grant.wilson@zen.co.uk, mikko.cal@gmail.com
Subject: Re: [PATCH 2/3] inotify: do not BUG on idr entries at inotify destruction
Date: Mon, 24 Aug 2009 12:23:19 -0700 (PDT) [thread overview]
Message-ID: <alpine.LFD.2.01.0908241220590.3158@localhost.localdomain> (raw)
In-Reply-To: <1251140949.25096.16.camel@dhcp231-106.rdu.redhat.com>
On Mon, 24 Aug 2009, Eric Paris wrote:
>
> You suspect correctly. :( I'll fix in my tree before I request a
> pull....
Can you change the WARN() to a WARN_ONCE() too.
Generally, we prefer the "ONCE" variant if there isn't some intrisic
reason why we'd want to know about each event. If there is some load that
triggers this, do you care about _how_many_times_ it happens, or about the
fact that it happens in the first place? In this case, I think it's the
"happens in the first place" case - once you see it a single time, the
rest of the reports aren't that interesting.
And using the ONCE thing means that we know it's not going to spam the
logs.
Linus
next prev parent reply other threads:[~2009-08-24 19:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-24 17:37 [PATCH 0/3] Inotify cleanup and idr race Eric Paris
2009-08-24 17:38 ` [PATCH 1/3] inotify: seperate new watch creation updating existing watches Eric Paris
2009-08-24 17:38 ` [PATCH 2/3] inotify: do not BUG on idr entries at inotify destruction Eric Paris
2009-08-24 18:34 ` Frans Pop
2009-08-24 19:09 ` Eric Paris
2009-08-24 19:23 ` Linus Torvalds [this message]
2009-08-24 19:32 ` Eric Paris
2009-08-24 20:36 ` Eric Paris
2009-08-25 11:42 ` Mikko C.
2009-08-25 14:18 ` Eric Paris
2009-08-25 16:43 ` Linus Torvalds
2009-08-25 17:17 ` Mikko C.
2009-08-24 17:38 ` [PATCH 3/3] inotify: fix locking around inotify watching in the idr Eric Paris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.01.0908241220590.3158@localhost.localdomain \
--to=torvalds@linux-foundation.org \
--cc=akpm@linux-foundation.org \
--cc=christoph.thielecke@gmx.de \
--cc=elendil@planet.nl \
--cc=eparis@redhat.com \
--cc=grant.wilson@zen.co.uk \
--cc=linux-fs-devel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mikko.cal@gmail.com \
--cc=viro@zeniv.linux.org.uk \
--cc=zdenek.kabelac@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome