mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] x86: kprobes: Remove remove bogus preempt_enable
@ 2011-07-23 12:52 Thomas Gleixner
  0 siblings, 0 replies; only message in thread
From: Thomas Gleixner @ 2011-07-23 12:52 UTC (permalink / raw)
  To: LKML; +Cc: x86

The CONFIG_PREEMPT=n section of setup_singlestep() contains:

    preempt_enable_no_resched();

That's bogus in the CONFIG_PREEMPT=n section and it just never blew up
because preempt_enable_no_resched() is a NOP there. Remove it.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
 arch/x86/kernel/kprobes.c |    1 -
 1 file changed, 1 deletion(-)

Index: linux-2.6-tip/arch/x86/kernel/kprobes.c
===================================================================
--- linux-2.6-tip.orig/arch/x86/kernel/kprobes.c
+++ linux-2.6-tip/arch/x86/kernel/kprobes.c
@@ -475,7 +475,6 @@ static void __kprobes setup_singlestep(s
 		 * stepping.
 		 */
 		regs->ip = (unsigned long)p->ainsn.insn;
-		preempt_enable_no_resched();
 		return;
 	}
 #endif

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2011-07-23 12:52 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-07-23 12:52 [PATCH] x86: kprobes: Remove remove bogus preempt_enable Thomas Gleixner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®