[PATCH] irq: Add EXPORT_SYMBOL to function of irq generic-chip

[PATCH] irq: Add EXPORT_SYMBOL to function of irq generic-chip

[Nobuhiro Iwamatsu]

Although some functions of of irq generic-chip can be used,
since EXPORT_SYMBOL is not specified, it cannot use.
This is revised that EXPORT_SYMBOL can be added and referred
to in functions.

Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
---
 kernel/irq/generic-chip.c |   14 ++++++++++++++
 1 files changed, 14 insertions(+), 0 deletions(-)

diff --git a/kernel/irq/generic-chip.c b/kernel/irq/generic-chip.c
index e38544d..8108811 100644
--- a/kernel/irq/generic-chip.c
+++ b/kernel/irq/generic-chip.c
@@ -27,6 +27,7 @@ static inline struct irq_chip_regs *cur_regs(struct irq_data *d)
 void irq_gc_noop(struct irq_data *d)
 {
 }
+EXPORT_SYMBOL(irq_gc_noop);
 
 /**
  * irq_gc_mask_disable_reg - Mask chip via disable register
@@ -45,6 +46,7 @@ void irq_gc_mask_disable_reg(struct irq_data *d)
 	gc->mask_cache &= ~mask;
 	irq_gc_unlock(gc);
 }
+EXPORT_SYMBOL(irq_gc_mask_disable_reg);
 
 /**
  * irq_gc_mask_set_mask_bit - Mask chip via setting bit in mask register
@@ -63,6 +65,7 @@ void irq_gc_mask_set_bit(struct irq_data *d)
 	irq_reg_writel(gc->mask_cache, gc->reg_base + cur_regs(d)->mask);
 	irq_gc_unlock(gc);
 }
+EXPORT_SYMBOL(irq_gc_mask_set_bit);
 
 /**
  * irq_gc_mask_set_mask_bit - Mask chip via clearing bit in mask register
@@ -81,6 +84,7 @@ void irq_gc_mask_clr_bit(struct irq_data *d)
 	irq_reg_writel(gc->mask_cache, gc->reg_base + cur_regs(d)->mask);
 	irq_gc_unlock(gc);
 }
+EXPORT_SYMBOL(irq_gc_mask_clr_bit);
 
 /**
  * irq_gc_unmask_enable_reg - Unmask chip via enable register
@@ -99,6 +103,7 @@ void irq_gc_unmask_enable_reg(struct irq_data *d)
 	gc->mask_cache |= mask;
 	irq_gc_unlock(gc);
 }
+EXPORT_SYMBOL(irq_gc_unmask_enable_reg);
 
 /**
  * irq_gc_ack_set_bit - Ack pending interrupt via setting bit
@@ -113,6 +118,7 @@ void irq_gc_ack_set_bit(struct irq_data *d)
 	irq_reg_writel(mask, gc->reg_base + cur_regs(d)->ack);
 	irq_gc_unlock(gc);
 }
+EXPORT_SYMBOL(irq_gc_ack_set_bit);
 
 /**
  * irq_gc_ack_clr_bit - Ack pending interrupt via clearing bit
@@ -127,6 +133,7 @@ void irq_gc_ack_clr_bit(struct irq_data *d)
 	irq_reg_writel(mask, gc->reg_base + cur_regs(d)->ack);
 	irq_gc_unlock(gc);
 }
+EXPORT_SYMBOL(irq_gc_ack_clr_bit);
 
 /**
  * irq_gc_mask_disable_reg_and_ack- Mask and ack pending interrupt
@@ -142,6 +149,7 @@ void irq_gc_mask_disable_reg_and_ack(struct irq_data *d)
 	irq_reg_writel(mask, gc->reg_base + cur_regs(d)->ack);
 	irq_gc_unlock(gc);
 }
+EXPORT_SYMBOL(irq_gc_mask_disable_reg_and_ack);
 
 /**
  * irq_gc_eoi - EOI interrupt
@@ -156,6 +164,7 @@ void irq_gc_eoi(struct irq_data *d)
 	irq_reg_writel(mask, gc->reg_base + cur_regs(d)->eoi);
 	irq_gc_unlock(gc);
 }
+EXPORT_SYMBOL(irq_gc_eoi);
 
 /**
  * irq_gc_set_wake - Set/clr wake bit for an interrupt
@@ -181,6 +190,7 @@ int irq_gc_set_wake(struct irq_data *d, unsigned int on)
 	irq_gc_unlock(gc);
 	return 0;
 }
+EXPORT_SYMBOL(irq_gc_set_wake);
 
 /**
  * irq_alloc_generic_chip - Allocate a generic chip and initialize it
@@ -211,6 +221,7 @@ irq_alloc_generic_chip(const char *name, int num_ct, unsigned int irq_base,
 	}
 	return gc;
 }
+EXPORT_SYMBOL(irq_alloc_generic_chip);
 
 /*
  * Separate lockdep class for interrupt chip which can nest irq_desc
@@ -258,6 +269,7 @@ void irq_setup_generic_chip(struct irq_chip_generic *gc, u32 msk,
 	}
 	gc->irq_cnt = i - gc->irq_base;
 }
+EXPORT_SYMBOL(irq_setup_generic_chip);
 
 /**
  * irq_setup_alt_chip - Switch to alternative chip
@@ -281,6 +293,7 @@ int irq_setup_alt_chip(struct irq_data *d, unsigned int type)
 	}
 	return -EINVAL;
 }
+EXPORT_SYMBOL(irq_setup_alt_chip);
 
 /**
  * irq_remove_generic_chip - Remove a chip
@@ -311,6 +324,7 @@ void irq_remove_generic_chip(struct irq_chip_generic *gc, u32 msk,
 		irq_modify_status(i, clr, set);
 	}
 }
+EXPORT_SYMBOL(irq_remove_generic_chip);
 
 #ifdef CONFIG_PM
 static int irq_gc_suspend(void)
-- 
1.7.6.3

Re: [PATCH] irq: Add EXPORT_SYMBOL to function of irq generic-chip

[Thomas Gleixner]

On Wed, 12 Oct 2011, Nobuhiro Iwamatsu wrote:

> Although some functions of of irq generic-chip can be used,
> since EXPORT_SYMBOL is not specified, it cannot use.

This does not make sense. In which context they can't be used?

> This is revised that EXPORT_SYMBOL can be added and referred
> to in functions.

EXPORT_SYMBOL_GPL if at all please.

And I'd rather avoid the exports, except those
 
> +EXPORT_SYMBOL(irq_alloc_generic_chip);
> +EXPORT_SYMBOL(irq_setup_generic_chip);
> +EXPORT_SYMBOL(irq_setup_alt_chip);
> +EXPORT_SYMBOL(irq_remove_generic_chip);

which are really necessary. To gain access to the various helper
functions we're better off to create a data structure with function
pointers.

struct irq_gc_functions {
       void (* irq_gc_noop)(...);
       ...
};

Instantiate this structure in kernel/irq/generic-chip.c, statically
initialize it with pointers to those helper functions and export that
data structure. That's way more efficient than having the overhead of
the symbol export for each of the functions.

Thanks,

	tglx

Re: [PATCH] irq: Add EXPORT_SYMBOL to function of irq generic-chip

[Nobuhiro Iwamatsu]

2011/10/12 Thomas Gleixner <tglx@linutronix.de>:
> On Wed, 12 Oct 2011, Nobuhiro Iwamatsu wrote:
>
>> Although some functions of of irq generic-chip can be used,
>> since EXPORT_SYMBOL is not specified, it cannot use.
>
> This does not make sense. In which context they can't be used?
>

Yes, this is mistake. Correctly, it is undefined error.

-----
ERROR: "irq_setup_generic_chip" [drivers/gpio/gpio-pch.ko] undefined!
ERROR: "irq_alloc_generic_chip" [drivers/gpio/gpio-pch.ko] undefined!
ERROR: "irq_setup_generic_chip" [drivers/gpio/gpio-ml-ioh.ko] undefined!
ERROR: "irq_alloc_generic_chip" [drivers/gpio/gpio-ml-ioh.ko] undefined!
-----

>> This is revised that EXPORT_SYMBOL can be added and referred
>> to in functions.
>
> EXPORT_SYMBOL_GPL if at all please.
>

Sure.

> And I'd rather avoid the exports, except those
>
>> +EXPORT_SYMBOL(irq_alloc_generic_chip);
>> +EXPORT_SYMBOL(irq_setup_generic_chip);
>> +EXPORT_SYMBOL(irq_setup_alt_chip);
>> +EXPORT_SYMBOL(irq_remove_generic_chip);
>
> which are really necessary. To gain access to the various helper
> functions we're better off to create a data structure with function
> pointers.
>
> struct irq_gc_functions {
>       void (* irq_gc_noop)(...);
>       ...
> };
>
> Instantiate this structure in kernel/irq/generic-chip.c, statically
> initialize it with pointers to those helper functions and export that
> data structure. That's way more efficient than having the overhead of
> the symbol export for each of the functions.
>

OK,  I will send the patch to which this function was added.

Thanks for your comments.

Best regards,
  Nobuhiro

-- 
Nobuhiro Iwamatsu