* Re: udelay minimum delay guarantee and maximum supported delay?
2012-03-09 14:37 udelay minimum delay guarantee and maximum supported delay? Tvrtko Ursulin
@ 2012-03-09 15:21 ` Tvrtko Ursulin
2012-03-09 19:55 ` Thomas Gleixner
1 sibling, 0 replies; 5+ messages in thread
From: Tvrtko Ursulin @ 2012-03-09 15:21 UTC (permalink / raw)
To: x86; +Cc: linux-kernel, Thomas Gleixner, Ingo Molnar, H. Peter Anvin
[Adding some people to the CC list, courtesy of get_maintainer.pl -f
arch/x86/lib/delay.c, if you consider that a good file choice for this.]
On Friday 09 Mar 2012 14:37:50 Tvrtko Ursulin wrote:
> Hi all,
>
> I was debugging some weird driver behaviour under 3.3.0-rc6+ (amd64) and
> eventually I got to discovering udelay's driver is issuing are occasionally
> short. That results in random hardware behaviour, but that is beside the
> point.
>
> Driver in question wants to delay for 500us at a time, which is not a
> terribly nice thing to do, but putting that aside and talking more in
> general I would have three questions:
>
> 1. Are 500us udelays supposed to work? (I know they are not recommended and
> I'll fix that.)
> 2. Should udelay guarantee it won't delay by less than the time asked?
> 3. Is ktime_get() considered accurate enough to measure how long udelay
> actually delayed? (Empirical evidence suggests it is, because hardware
> weirdness correlates perfectly with occurences of these short udelays.)
>
> If answers to all are yes then we might have a bug here.
>
> Because I am seeing udelay(500) (_occasionally_) being short, and that by
> delaying for some duration between 0us (yep) and 491us.
>
> As far as I can see this box is using TSC delay and CPU (Intel(R) Core(TM)
> i5-2400S CPU @ 2.50GH) exposes the constant_tsc flag:
>
> [ 1.717050] Refined TSC clocksource calibration: 2494.334 MHz.
> [ 1.717054] Switching to clocksource tsc
>
> Am I missing something and what are your opinions?
>
> Thanks,
>
> Tvrtko
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: udelay minimum delay guarantee and maximum supported delay?
2012-03-09 14:37 udelay minimum delay guarantee and maximum supported delay? Tvrtko Ursulin
2012-03-09 15:21 ` Tvrtko Ursulin
@ 2012-03-09 19:55 ` Thomas Gleixner
2012-03-09 20:11 ` Linus Torvalds
1 sibling, 1 reply; 5+ messages in thread
From: Thomas Gleixner @ 2012-03-09 19:55 UTC (permalink / raw)
To: Tvrtko Ursulin; +Cc: x86, LKML, Glauber Costa, Linus Torvalds
On Fri, 9 Mar 2012, Tvrtko Ursulin wrote:
> Hi all,
>
> I was debugging some weird driver behaviour under 3.3.0-rc6+ (amd64) and
> eventually I got to discovering udelay's driver is issuing are occasionally
> short. That results in random hardware behaviour, but that is beside the
> point.
>
> Driver in question wants to delay for 500us at a time, which is not a terribly
> nice thing to do, but putting that aside and talking more in general I would
> have three questions:
>
> 1. Are 500us udelays supposed to work? (I know they are not recommended and
> I'll fix that.)
Yep, though it's crap, but you know that :)
> 2. Should udelay guarantee it won't delay by less than the time asked?
Yep
> 3. Is ktime_get() considered accurate enough to measure how long udelay
> actually delayed? (Empirical evidence suggests it is, because hardware
> weirdness correlates perfectly with occurences of these short udelays.)
Yep
> If answers to all are yes then we might have a bug here.
We have :(
> Because I am seeing udelay(500) (_occasionally_) being short, and that by
> delaying for some duration between 0us (yep) and 491us.
Sigh. That's broken and turned into a random delay generator for 64bit
as of commit f0fbf0abc (x86: integrate delay functions). Patch below.
Thanks,
tglx
--------------
Subject: x86: Derandom delay_tsc for 64 bit
commit f0fbf0abc (x86: integrate delay functions) converted
delay_tsc() into a random delay generator for 64 bit. The reason is
that it merged the mostly identical versions of delay_32.c and
delay_64.c. Though the subtle difference of the result was:
static void delay_tsc(unsigned long loops)
{
- unsigned bclock, now;
+ unsigned long bclock, now;
Now the function uses rdtscl() which returns the lower 32bit of the
TSC. On 32bit that's not problematic as unsigned long is 32bit. On 64
bit this fails when the lower 32bit are close to wrap around when
bclock is read, because the following check
if ((now - bclock) >= loops)
break;
evaluated to true on 64bit for e.g. bclock = 0xffffffff and now = 0
because the unsigned long (now - bclock) of these values results in
0xffffffff00000001 which is definitely larger than the loops
value. That explains Tvortkos observation:
"Because I am seeing udelay(500) (_occasionally_) being short, and
that by delaying for some duration between 0us (yep) and 491us."
Make those variables explicitely u32 again, so this works for both 32
and 64 bit.
Reported-by: Tvrtko Ursulin <tvrtko.ursulin@onelan.co.uk>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: stable@vger.kernel.org # >= 2.6.27
diff --git a/arch/x86/lib/delay.c b/arch/x86/lib/delay.c
index fc45ba8..e395693 100644
--- a/arch/x86/lib/delay.c
+++ b/arch/x86/lib/delay.c
@@ -48,9 +48,9 @@ static void delay_loop(unsigned long loops)
}
/* TSC based delay: */
-static void delay_tsc(unsigned long loops)
+static void delay_tsc(unsigned long __loops)
{
- unsigned long bclock, now;
+ u32 bclock, now, loops = __loops;
int cpu;
preempt_disable();
^ permalink raw reply [flat|nested] 5+ messages in thread