* [PATCH] Fix build error with !SMP && !GENERIC_HARDIRQS
@ 2012-03-23 7:23 Alexander Shiyan
2012-03-23 7:46 ` Geert Uytterhoeven
2012-03-23 9:08 ` Thomas Gleixner
0 siblings, 2 replies; 6+ messages in thread
From: Alexander Shiyan @ 2012-03-23 7:23 UTC (permalink / raw)
To: Thomas Gleixner; +Cc: linux-kernel, Alexander Shiyan
When compile kernel with !SMP && !GENERIC_HARDIRQS we are have
following error:
CC kernel/irq/manage.o
kernel/irq/manage.c:41: error: expected identifier or '(' before 'asm'
This error appears because header contain other definition for
synchronize_irq in include/linux/hardirq.h.
extern void synchronize_irq(unsigned int irq);
This patch fix this problem.
Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
---
kernel/irq/manage.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c
index b0ccd1a..854a463 100644
--- a/kernel/irq/manage.c
+++ b/kernel/irq/manage.c
@@ -28,6 +28,7 @@ static int __init setup_forced_irqthreads(char *arg)
early_param("threadirqs", setup_forced_irqthreads);
#endif
+#if !defined(synchronize_irq)
/**
* synchronize_irq - wait for pending IRQ handlers (on other CPUs)
* @irq: interrupt number to wait for
@@ -71,6 +72,7 @@ void synchronize_irq(unsigned int irq)
wait_event(desc->wait_for_threads, !atomic_read(&desc->threads_active));
}
EXPORT_SYMBOL(synchronize_irq);
+#endif
#ifdef CONFIG_SMP
cpumask_var_t irq_default_affinity;
--
1.7.3.4
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] Fix build error with !SMP && !GENERIC_HARDIRQS
2012-03-23 7:23 [PATCH] Fix build error with !SMP && !GENERIC_HARDIRQS Alexander Shiyan
@ 2012-03-23 7:46 ` Geert Uytterhoeven
2012-03-23 8:13 ` Re[2]: " Alexander Shiyan
2012-03-23 9:08 ` Thomas Gleixner
1 sibling, 1 reply; 6+ messages in thread
From: Geert Uytterhoeven @ 2012-03-23 7:46 UTC (permalink / raw)
To: Alexander Shiyan; +Cc: Thomas Gleixner, linux-kernel
On Fri, Mar 23, 2012 at 08:23, Alexander Shiyan <shc_work@mail.ru> wrote:
> When compile kernel with !SMP && !GENERIC_HARDIRQS we are have
> following error:
Is this on uniprocessor s390?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 6+ messages in thread* Re[2]: [PATCH] Fix build error with !SMP && !GENERIC_HARDIRQS
2012-03-23 7:46 ` Geert Uytterhoeven
@ 2012-03-23 8:13 ` Alexander Shiyan
2012-03-23 9:19 ` Thomas Gleixner
2012-03-23 10:28 ` Geert Uytterhoeven
0 siblings, 2 replies; 6+ messages in thread
From: Alexander Shiyan @ 2012-03-23 8:13 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: Thomas Gleixner, linux-kernel
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=utf-8, Size: 742 bytes --]
Fri, 23 Mar 2012 08:46:15 +0100 от Geert Uytterhoeven <geert@linux-m68k.org>:
> On Fri, Mar 23, 2012 at 08:23, Alexander Shiyan <shc_work@mail.ru> wrote:
> > When compile kernel with !SMP && !GENERIC_HARDIRQS we are have
> > following error:
> Is this on uniprocessor s390?
No. I trying to fix other problem with ARM Cirrus Logic EP7312 that do not work since 2.6.30-rc1.
The problem appear after commit:
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=commit;h=c61b79b6ef266890954213a701d8f6021d8c1289
I just playing with this commit and found this compile error.ÿôèº{.nÇ+‰·Ÿ®‰†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a¢f£¢·hšïêÿ‘êçz_è®\x03(階ŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨èÚ&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥
^ permalink raw reply [flat|nested] 6+ messages in thread* Re[2]: [PATCH] Fix build error with !SMP && !GENERIC_HARDIRQS
2012-03-23 8:13 ` Re[2]: " Alexander Shiyan
@ 2012-03-23 9:19 ` Thomas Gleixner
2012-03-23 10:28 ` Geert Uytterhoeven
1 sibling, 0 replies; 6+ messages in thread
From: Thomas Gleixner @ 2012-03-23 9:19 UTC (permalink / raw)
To: Alexander Shiyan; +Cc: Geert Uytterhoeven, linux-kernel
[-- Attachment #1: Type: TEXT/PLAIN, Size: 873 bytes --]
On Fri, 23 Mar 2012, Alexander Shiyan wrote:
> Fri, 23 Mar 2012 08:46:15 +0100 от Geert Uytterhoeven <geert@linux-m68k.org>:
> > On Fri, Mar 23, 2012 at 08:23, Alexander Shiyan <shc_work@mail.ru> wrote:
> > > When compile kernel with !SMP && !GENERIC_HARDIRQS we are have
> > > following error:
> > Is this on uniprocessor s390?
> No. I trying to fix other problem with ARM Cirrus Logic EP7312 that do not work since 2.6.30-rc1.
> The problem appear after commit:
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=commit;h=c61b79b6ef266890954213a701d8f6021d8c1289
>
> I just playing with this commit and found this compile error.
Which was probably caused by you playing with that commit.
Again arch/arm has GENERIC_HARDIRQS=y and therefor the problem does
not exist. For GENERIC_HARDIRQS=n that file is not compiled.
Ergo: -ENOPROBLEM
Thanks,
tglx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Re[2]: [PATCH] Fix build error with !SMP && !GENERIC_HARDIRQS
2012-03-23 8:13 ` Re[2]: " Alexander Shiyan
2012-03-23 9:19 ` Thomas Gleixner
@ 2012-03-23 10:28 ` Geert Uytterhoeven
1 sibling, 0 replies; 6+ messages in thread
From: Geert Uytterhoeven @ 2012-03-23 10:28 UTC (permalink / raw)
To: Alexander Shiyan; +Cc: Thomas Gleixner, linux-kernel
On Fri, Mar 23, 2012 at 09:13, Alexander Shiyan <shc_work@mail.ru> wrote:
> Fri, 23 Mar 2012 08:46:15 +0100 от Geert Uytterhoeven <geert@linux-m68k.org>:
>> On Fri, Mar 23, 2012 at 08:23, Alexander Shiyan <shc_work@mail.ru> wrote:
>> > When compile kernel with !SMP && !GENERIC_HARDIRQS we are have
>> > following error:
>> Is this on uniprocessor s390?
> No. I trying to fix other problem with ARM Cirrus Logic EP7312 that do not work since 2.6.30-rc1.
Then it should not happen, as s390 is the sole remaining arch that doesn't use
generic hardirqs.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Fix build error with !SMP && !GENERIC_HARDIRQS
2012-03-23 7:23 [PATCH] Fix build error with !SMP && !GENERIC_HARDIRQS Alexander Shiyan
2012-03-23 7:46 ` Geert Uytterhoeven
@ 2012-03-23 9:08 ` Thomas Gleixner
1 sibling, 0 replies; 6+ messages in thread
From: Thomas Gleixner @ 2012-03-23 9:08 UTC (permalink / raw)
To: Alexander Shiyan; +Cc: linux-kernel
On Fri, 23 Mar 2012, Alexander Shiyan wrote:
> When compile kernel with !SMP && !GENERIC_HARDIRQS we are have
> following error:
> CC kernel/irq/manage.o
> kernel/irq/manage.c:41: error: expected identifier or '(' before 'asm'
>
> This error appears because header contain other definition for
> synchronize_irq in include/linux/hardirq.h.
> extern void synchronize_irq(unsigned int irq);
>
> This patch fix this problem.
Errm, which problem ?
kernel/irq/* is not compiled at all when CONFIG_GENERIC_HARDIRQS=n.
So nothing to fix here.
Thanks,
tglx
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-03-23 16:37 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-03-23 7:23 [PATCH] Fix build error with !SMP && !GENERIC_HARDIRQS Alexander Shiyan
2012-03-23 7:46 ` Geert Uytterhoeven
2012-03-23 8:13 ` Re[2]: " Alexander Shiyan
2012-03-23 9:19 ` Thomas Gleixner
2012-03-23 10:28 ` Geert Uytterhoeven
2012-03-23 9:08 ` Thomas Gleixner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®