mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: "Liu, Chuansheng" <chuansheng.liu@intel.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] genirq: for edge interrupt IRQS_ONESHOT support with irq thread
Date: Fri, 12 Oct 2012 22:53:56 +0200 (CEST)	[thread overview]
Message-ID: <alpine.LFD.2.02.1210122252230.2779@ionos> (raw)
In-Reply-To: <27240C0AC20F114CBF8149A2696CBE4A195A6B@SHSMSX101.ccr.corp.intel.com>

On Fri, 12 Oct 2012, Liu, Chuansheng wrote:

> > On SMP an interrupt which is raised after the ack() again before the
> > handler finishes, can invoke another delivery on a different CPU,
> > which then sees the IRQ_INPROGESS flag, masks it and flags it
> > PENDING. When the primary handler on the first CPU returns, it sees
> > the PENDING flag, unmasks and invokes the handler another time.
> In this case, when IRQ_INPROGRESS flag is set, on another CPU, it will
> mask and ack it, if before the primary handler on the first CPU returns,
> the edge interrupt is raised again, it will be lost, right?
> So I think set PENDING just confirm one time, it just depends on primary handler
> execution time and irq frequency.

It does NOT matter. We marked it PENDING. And that guarantees that we
invoke the handler again after unmasking. And that keeps stuff rolling.

We would lose when we masked and did not notice that there was one,
but we notice and store that information with the PENDING flag.



  parent reply	other threads:[~2012-10-12 20:53 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-12 12:31 Chuansheng Liu
2012-10-12 12:31 ` Thomas Gleixner
2012-10-12 12:38   ` Liu, Chuansheng
2012-10-12 12:46     ` Thomas Gleixner
2012-10-12 13:03       ` Liu, Chuansheng
2012-10-12 13:47         ` Thomas Gleixner
2012-10-12 14:35           ` Liu, Chuansheng
2012-10-12 20:58             ` Thomas Gleixner
2012-10-12 14:57           ` Liu, Chuansheng
2012-10-12 15:24             ` anish kumar
2012-10-12 15:29               ` Liu, Chuansheng
2012-10-12 15:37                 ` anish kumar
2012-10-12 20:52                 ` Thomas Gleixner
2012-10-13  5:21                   ` anish kumar
2012-10-21 14:45                     ` anish kumar
2012-10-12 20:53             ` Thomas Gleixner [this message]
2012-10-12 13:39       ` Liu, Chuansheng
2012-10-12 15:32       ` irq/manage.c wrong comment( ? ) anish kumar
2012-10-21 14:46         ` anish kumar
2012-10-24  9:28           ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.02.1210122252230.2779@ionos \
    --to=tglx@linutronix.de \
    --cc=chuansheng.liu@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome