From: Thomas Gleixner <tglx@linutronix.de>
To: anish kumar <anish198519851985@gmail.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: irq/manage.c wrong comment( ? )
Date: Wed, 24 Oct 2012 11:28:20 +0200 (CEST) [thread overview]
Message-ID: <alpine.LFD.2.02.1210241126590.2756@ionos> (raw)
In-Reply-To: <1350830795.9435.1.camel@anish-Inspiron-N5050>
On Sun, 21 Oct 2012, anish kumar wrote:
> ping...
Oh well.
> On Sat, 2012-10-13 at 00:32 +0900, anish kumar wrote:?
> > Hello tglx,
> >
> > I just found the below inconsistency while going through the code.
> >
> >
> > kernel/irq/manage.c
> >
> > if (new->flags & IRQF_ONESHOT) {
> > /*
> > * The thread_mask for the action is or'ed to
> > * desc->thread_active to indicate that the
> > * IRQF_ONESHOT thread handler has been woken, but not
> > * yet finished. The bit is cleared when a thread
> > * completes. When all threads of a shared interr
> >
> > Shouldn't this "desc->thread_active" be desc->threads_active ??
That's obvious, right? Please send a proper patch if you think it's
really that important.
Thanks,
tglx
prev parent reply other threads:[~2012-10-24 9:28 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-12 12:31 [PATCH] genirq: for edge interrupt IRQS_ONESHOT support with irq thread Chuansheng Liu
2012-10-12 12:31 ` Thomas Gleixner
2012-10-12 12:38 ` Liu, Chuansheng
2012-10-12 12:46 ` Thomas Gleixner
2012-10-12 13:03 ` Liu, Chuansheng
2012-10-12 13:47 ` Thomas Gleixner
2012-10-12 14:35 ` Liu, Chuansheng
2012-10-12 20:58 ` Thomas Gleixner
2012-10-12 14:57 ` Liu, Chuansheng
2012-10-12 15:24 ` anish kumar
2012-10-12 15:29 ` Liu, Chuansheng
2012-10-12 15:37 ` anish kumar
2012-10-12 20:52 ` Thomas Gleixner
2012-10-13 5:21 ` anish kumar
2012-10-21 14:45 ` anish kumar
2012-10-12 20:53 ` Thomas Gleixner
2012-10-12 13:39 ` Liu, Chuansheng
2012-10-12 15:32 ` irq/manage.c wrong comment( ? ) anish kumar
2012-10-21 14:46 ` anish kumar
2012-10-24 9:28 ` Thomas Gleixner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.02.1210241126590.2756@ionos \
--to=tglx@linutronix.de \
--cc=anish198519851985@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome