From: "Maciej W. Rozycki" <macro@linux-mips.org>
To: Andreas Ruprecht <rupran@einserver.de>
Cc: Ralf Baechle <ralf@linux-mips.org>,
linux-mips@linux-mips.org, linux-kernel@vger.kernel.org,
Valentin Rothberg <valentinrothberg@gmail.com>,
Paul Bolle <pebolle@tiscali.nl>
Subject: Re: [PATCH] MIPS: mm: Remove dead macro definitions
Date: Fri, 13 Feb 2015 19:50:18 +0000 (GMT) [thread overview]
Message-ID: <alpine.LFD.2.11.1502131949190.22715@eddie.linux-mips.org> (raw)
In-Reply-To: <1423748572-31012-1-git-send-email-rupran@einserver.de>
On Thu, 12 Feb 2015, Andreas Ruprecht wrote:
> In commit c441d4a54c6e ("MIPS: mm: Only build one microassembler that
> is suitable"), the Makefile at arch/mips/mm was rewritten to only
> build the "right" microassembler file, depending on whether
> CONFIG_CPU_MICROMIPS is set or not.
>
> In the files, however, there are still preprocessor definitions
> depending on CONFIG_CPU_MICROMIPS. The #ifdef around them can now
> never evaluate to true, so let's remove them altogether.
>
> This inconsistency was found using the undertaker-checkpatch tool.
>
> Signed-off-by: Andreas Ruprecht <rupran@einserver.de>
> ---
Reviewed-by: Maciej W. Rozycki <macro@linux-mips.org>
Thanks for catching it!
Maciej
prev parent reply other threads:[~2015-02-13 19:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-12 13:42 Andreas Ruprecht
2015-02-13 19:50 ` Maciej W. Rozycki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.11.1502131949190.22715@eddie.linux-mips.org \
--to=macro@linux-mips.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=pebolle@tiscali.nl \
--cc=ralf@linux-mips.org \
--cc=rupran@einserver.de \
--cc=valentinrothberg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®