From: James Simmons <jsimmons@infradead.org>
To: Baoyou Xie <baoyou.xie@linaro.org>
Cc: oleg.drokin@intel.com, andreas.dilger@intel.com,
gregkh@linuxfoundation.org, bobijam.xu@intel.com,
jinshan.xiong@intel.com, lai.siyao@intel.com,
mike.rapoport@gmail.com, amitoj1606@gmail.com,
devel@driverdev.osuosl.org, arnd@arndb.de, xie.baoyou@zte.com.cn,
linux-kernel@vger.kernel.org, lustre-devel@lists.lustre.org
Subject: Re: [PATCH] staging/lustre/lov: add missing header dependencies
Date: Thu, 8 Sep 2016 18:59:24 +0100 (BST) [thread overview]
Message-ID: <alpine.LFD.2.20.1609081851520.14646@casper.infradead.org> (raw)
In-Reply-To: <1473324508-9294-1-git-send-email-baoyou.xie@linaro.org>
> We get 1 warning when building kernel with W=1:
> drivers/staging/lustre/lustre/lov/lov_object.c:956:23: warning: no previous prototype for 'lov_lsm_get' [-Wmissing-prototypes]
> drivers/staging/lustre/lustre/lov/lov_object.c:972:6: warning: no previous prototype for 'lov_lsm_put' [-Wmissing-prototypes]
> drivers/staging/lustre/lustre/lov/lov_object.c:979:5: warning: no previous prototype for 'lov_read_and_clear_async_rc' [-Wmissing-prototypes]
>
> In fact, these functions are declared in ../llite/vvp_internal.h,
> so this patch add missing header dependencies.
>
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
Nak. The header vvp_internal.h is meant to private to the llite layer.
Looking at the coming patch updates I see lov_lsm_[put|get] will not be
used in the lov later. Now lov_read_and_clear_async is still used in
both layers. The header used for this case is cl_object.h. Might rename
that function to be consistent with the rest of the header. I will look
into a cleanup for this.
> ---
> drivers/staging/lustre/lustre/lov/lov_object.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/lustre/lustre/lov/lov_object.c b/drivers/staging/lustre/lustre/lov/lov_object.c
> index f9621b0..912c416 100644
> --- a/drivers/staging/lustre/lustre/lov/lov_object.c
> +++ b/drivers/staging/lustre/lustre/lov/lov_object.c
> @@ -38,6 +38,7 @@
> #define DEBUG_SUBSYSTEM S_LOV
>
> #include "lov_cl_internal.h"
> +#include "../llite/vvp_internal.h"
>
> /** \addtogroup lov
> * @{
> --
> 2.7.4
>
> _______________________________________________
> devel mailing list
> devel@linuxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
>
next prev parent reply other threads:[~2016-09-08 17:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-08 8:48 Baoyou Xie
2016-09-08 17:59 ` James Simmons [this message]
2016-09-26 18:23 ` [lustre-devel] " James Simmons
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.20.1609081851520.14646@casper.infradead.org \
--to=jsimmons@infradead.org \
--cc=amitoj1606@gmail.com \
--cc=andreas.dilger@intel.com \
--cc=arnd@arndb.de \
--cc=baoyou.xie@linaro.org \
--cc=bobijam.xu@intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jinshan.xiong@intel.com \
--cc=lai.siyao@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lustre-devel@lists.lustre.org \
--cc=mike.rapoport@gmail.com \
--cc=oleg.drokin@intel.com \
--cc=xie.baoyou@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®