From: James Simmons <jsimmons@infradead.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Baoyou Xie <baoyou.xie@linaro.org>,
oleg.drokin@intel.com, andreas.dilger@intel.com,
gregkh@linuxfoundation.org, di.wang@intel.com,
john.hammond@intel.com, fan.yong@intel.com,
lustre-devel@lists.lustre.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, xie.baoyou@zte.com.cn
Subject: Re: [PATCH] staging: lustre: lmv: add missing function declaration
Date: Sun, 18 Sep 2016 21:53:46 +0100 (BST) [thread overview]
Message-ID: <alpine.LFD.2.20.1609182152220.31599@casper.infradead.org> (raw)
In-Reply-To: <2318806.4yLNEl44ta@wuerfel>
> On Sunday, September 18, 2016 8:43:18 PM CEST James Simmons wrote:
> >
> > Nak. I'm not seeing this error with W=1. Also if you look
> > lmv_pack_md() is only used in lmv_obd.c and the function
> > appears early in the file before it is used, so no prototype
> > missing errors should happen.
>
> So it should be marked "static" and the EXPORT_SYMBOL() removed,
> right?
Already done. See patch
[PATCH 109/124] staging: lustre: misc: remove unnecessary EXPORT_SYMBOL
which is from Frank Zago which I just pushed to Greg.
prev parent reply other threads:[~2016-09-18 20:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-18 11:39 Baoyou Xie
2016-09-18 19:43 ` James Simmons
2016-09-18 20:35 ` Arnd Bergmann
2016-09-18 20:53 ` James Simmons [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.20.1609182152220.31599@casper.infradead.org \
--to=jsimmons@infradead.org \
--cc=andreas.dilger@intel.com \
--cc=arnd@arndb.de \
--cc=baoyou.xie@linaro.org \
--cc=devel@driverdev.osuosl.org \
--cc=di.wang@intel.com \
--cc=fan.yong@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=john.hammond@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lustre-devel@lists.lustre.org \
--cc=oleg.drokin@intel.com \
--cc=xie.baoyou@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®