From: James Simmons <jsimmons@infradead.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Oleg Drokin <oleg.drokin@intel.com>,
"John L. Hammond" <john.hammond@intel.com>,
Andreas Dilger <andreas.dilger@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Amitoj Kaur Chawla <amitoj1606@gmail.com>,
lustre-devel@lists.lustre.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] staging: lustre: lov: crash in error handling
Date: Thu, 10 Nov 2016 19:44:57 +0000 (GMT) [thread overview]
Message-ID: <alpine.LFD.2.20.1611101944280.31600@casper.infradead.org> (raw)
In-Reply-To: <20161110194105.GB18347@mwanda>
> We accidentally made this unsigned so now the error handling will loop
> until it crashes.
>
> Fixes: 55051039fdad ('staging: lustre: lov: remove LSM from struct lustre_md')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Yep. I just sent a patch to fix that.
> diff --git a/drivers/staging/lustre/lustre/lov/lov_ea.c b/drivers/staging/lustre/lustre/lov/lov_ea.c
> index 53db170..2e2abed 100644
> --- a/drivers/staging/lustre/lustre/lov/lov_ea.c
> +++ b/drivers/staging/lustre/lustre/lov/lov_ea.c
> @@ -81,7 +81,7 @@ struct lov_stripe_md *lsm_alloc_plain(u16 stripe_count)
> size_t oinfo_ptrs_size, lsm_size;
> struct lov_stripe_md *lsm;
> struct lov_oinfo *loi;
> - unsigned int i;
> + int i;
>
> LASSERT(stripe_count <= LOV_MAX_STRIPE_COUNT);
>
>
prev parent reply other threads:[~2016-11-10 19:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-10 19:41 Dan Carpenter
2016-11-10 19:44 ` James Simmons [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.20.1611101944280.31600@casper.infradead.org \
--to=jsimmons@infradead.org \
--cc=amitoj1606@gmail.com \
--cc=andreas.dilger@intel.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=john.hammond@intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lustre-devel@lists.lustre.org \
--cc=oleg.drokin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®