From: James Simmons <jsimmons@infradead.org>
To: Joe Perches <joe@perches.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org,
Andreas Dilger <andreas.dilger@intel.com>,
Oleg Drokin <oleg.drokin@intel.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Lustre Development List <lustre-devel@lists.lustre.org>
Subject: Re: [PATCH 5/6] staging: lustre: lustre: several over 80 characters cleanups
Date: Thu, 15 Jun 2017 17:06:30 +0100 (BST) [thread overview]
Message-ID: <alpine.LFD.2.20.1706151704110.11322@casper.infradead.org> (raw)
In-Reply-To: <1497464128.18751.59.camel@perches.com>
> On Wed, 2017-06-14 at 11:01 -0400, James Simmons wrote:
> > Cleanup many of the over 80 characters reported by checkpatch
>
> Please don't let checkpatch get in the way of lustre
> readability.
>
> lustre commonly uses very long identifiers.
> Long identifiers and 80 columns don't mix well.
>
> It might be simpler to declare in some document that
> lustre uses lines of up to whatever length and require
> that checkpatch should be used with the --max-line-length
> option when run on lustre code.
Greg would you be okay with this? If we changed to a max-line-length to
say 128 thay would mean very few checkpatch issues would remain.
next prev parent reply other threads:[~2017-06-15 16:06 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-14 15:01 [PATCH 0/6] staging: lustre: lustre: assortment of checkpatch cleanups James Simmons
2017-06-14 15:01 ` [PATCH 1/6] staging: lustre: lustre: resolve "use spaces between elements" checkpatch errors James Simmons
2017-06-14 18:10 ` Joe Perches
2017-06-15 16:03 ` James Simmons
2017-06-15 16:19 ` Joe Perches
2017-06-15 16:57 ` James Simmons
2017-06-15 17:04 ` Joe Perches
2017-06-15 17:16 ` James Simmons
2017-06-14 15:01 ` [PATCH 2/6] staging: lustre: lustre: make all struct file_operations constant James Simmons
2017-06-14 15:01 ` [PATCH 3/6] staging: lustre: lustre: fix all bare unsigned usage James Simmons
2017-06-14 15:01 ` [PATCH 4/6] staging: lustre: lustre: add all missing indentifier names James Simmons
2017-06-14 15:01 ` [PATCH 5/6] staging: lustre: lustre: several over 80 characters cleanups James Simmons
2017-06-14 18:15 ` Joe Perches
2017-06-15 16:06 ` James Simmons [this message]
2017-06-15 16:12 ` Joe Perches
2017-06-23 16:12 ` Greg Kroah-Hartman
2017-06-23 16:15 ` Greg Kroah-Hartman
2017-06-14 15:01 ` [PATCH 6/6] staging: lustre: lustre: fix all braces issues reported by checkpatch James Simmons
2017-06-14 18:25 ` Joe Perches
2017-06-15 16:38 ` James Simmons
2017-06-15 16:58 ` Joe Perches
2017-06-23 16:17 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.20.1706151704110.11322@casper.infradead.org \
--to=jsimmons@infradead.org \
--cc=andreas.dilger@intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lustre-devel@lists.lustre.org \
--cc=oleg.drokin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®