From: "Maciej W. Rozycki" <macro@linux-mips.org>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: Ralf Baechle <ralf@linux-mips.org>,
"David S. Miller" <davem@davemloft.net>,
Andrew Morton <akpm@linux-foundation.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] defxx: Fix a sentinel at the end of a 'eisa_device_id' structure
Date: Sun, 2 Feb 2020 19:12:13 +0000 (GMT) [thread overview]
Message-ID: <alpine.LFD.2.21.2002021858330.683661@eddie.linux-mips.org> (raw)
In-Reply-To: <20200202142341.22124-1-christophe.jaillet@wanadoo.fr>
On Sun, 2 Feb 2020, Christophe JAILLET wrote:
> 'struct eisa_device_id' must be ended by an empty string, not a NULL
> pointer. Otherwise, a NULL pointer dereference may occur in
> 'eisa_bus_match()'.
Umm, that's weird code there in `eisa_bus_match' (I do hope at least GCC
optimises the `strlen' away nowadays and checks for the character pointed
being null instead), but as usually with old stuff let's keep changes to
the minimum. So:
Acked-by: Maciej W. Rozycki <macro@linux-mips.org>
Thanks for the fix!
Maciej
next prev parent reply other threads:[~2020-02-02 19:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-02 14:23 Christophe JAILLET
2020-02-02 19:12 ` Maciej W. Rozycki [this message]
2020-02-03 9:55 ` Dan Carpenter
2020-02-03 10:20 ` Maciej W. Rozycki
2020-02-03 17:38 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.21.2002021858330.683661@eddie.linux-mips.org \
--to=macro@linux-mips.org \
--cc=akpm@linux-foundation.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=davem@davemloft.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®