From: "Maciej W. Rozycki" <macro@linux-mips.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
Ralf Baechle <ralf@linux-mips.org>,
"David S. Miller" <davem@davemloft.net>,
Andrew Morton <akpm@linux-foundation.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] defxx: Fix a sentinel at the end of a 'eisa_device_id' structure
Date: Mon, 3 Feb 2020 10:20:46 +0000 (GMT) [thread overview]
Message-ID: <alpine.LFD.2.21.2002031015530.752735@eddie.linux-mips.org> (raw)
In-Reply-To: <20200203095553.GN1778@kadam>
On Mon, 3 Feb 2020, Dan Carpenter wrote:
> > diff --git a/drivers/net/fddi/defxx.c b/drivers/net/fddi/defxx.c
> > index 077c68498f04..7ef0c57f07c6 100644
> > --- a/drivers/net/fddi/defxx.c
> > +++ b/drivers/net/fddi/defxx.c
> > @@ -3768,11 +3768,11 @@ static void dfx_pci_unregister(struct pci_dev *pdev)
> >
> > #ifdef CONFIG_EISA
> > static const struct eisa_device_id dfx_eisa_table[] = {
> > - { "DEC3001", DEFEA_PROD_ID_1 },
> > - { "DEC3002", DEFEA_PROD_ID_2 },
> > - { "DEC3003", DEFEA_PROD_ID_3 },
> > - { "DEC3004", DEFEA_PROD_ID_4 },
> > - { }
> > + { "DEC3001", DEFEA_PROD_ID_1 },
> > + { "DEC3002", DEFEA_PROD_ID_2 },
> > + { "DEC3003", DEFEA_PROD_ID_3 },
> > + { "DEC3004", DEFEA_PROD_ID_4 },
> > + { "" }
>
> You haven't changed runtime at all. :P (struct eisa_device_id)->sig[]
> is an array, not a pointer. There is no NULL dereference because an
> array in the middle of another array can't be NULL.
Right, the code is good as it stands (I should have more faith in my past
achievements ;) ). Except for the whitespace issue, which I suppose might
not be worth bothering to fix. Thanks for your meticulousness!
Maciej
next prev parent reply other threads:[~2020-02-03 10:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-02 14:23 Christophe JAILLET
2020-02-02 19:12 ` Maciej W. Rozycki
2020-02-03 9:55 ` Dan Carpenter
2020-02-03 10:20 ` Maciej W. Rozycki [this message]
2020-02-03 17:38 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.21.2002031015530.752735@eddie.linux-mips.org \
--to=macro@linux-mips.org \
--cc=akpm@linux-foundation.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=dan.carpenter@oracle.com \
--cc=davem@davemloft.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®