From: "Maciej W. Rozycki" <macro@linux-mips.org>
To: Anders Roxell <anders.roxell@linaro.org>
Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
natechancellor@gmail.com, ndesaulniers@google.com,
linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
clang-built-linux@googlegroups.com
Subject: Re: [PATCH] mips: lib: uncached: fix uninitialized variable 'sp'
Date: Sun, 6 Dec 2020 14:33:33 +0000 (GMT) [thread overview]
Message-ID: <alpine.LFD.2.21.2012061431190.656242@eddie.linux-mips.org> (raw)
In-Reply-To: <alpine.LFD.2.21.2012060915460.656242@eddie.linux-mips.org>
On Sun, 6 Dec 2020, Maciej W. Rozycki wrote:
> I think this should be OK once the issues I mentioned here have been
> addressed.
Or alternatively making the variable global would possibly be a better
fix as it would let the compiler decide if to waste another register to
keep a copy of $sp.
Maciej
prev parent reply other threads:[~2020-12-06 14:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-27 8:39 Anders Roxell
2020-11-30 20:22 ` Nick Desaulniers
2020-12-01 0:50 ` Anders Roxell
2020-12-06 9:36 ` Maciej W. Rozycki
2020-12-06 14:33 ` Maciej W. Rozycki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.21.2012061431190.656242@eddie.linux-mips.org \
--to=macro@linux-mips.org \
--cc=anders.roxell@linaro.org \
--cc=clang-built-linux@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=natechancellor@gmail.com \
--cc=ndesaulniers@google.com \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®