From: Jiri Kosina <jikos@kernel.org>
To: Brent Adam <brentadamdev@gmail.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
Brent Adam <brentadam@smarttech.com>
Subject: Re: [PATCH] HID: hid-multitouch.c: fix formatting warnings
Date: Tue, 29 Sep 2015 14:59:03 +0200 (CEST) [thread overview]
Message-ID: <alpine.LNX.2.00.1509291457360.30132@pobox.suse.cz> (raw)
In-Reply-To: <1443470594-9878-1-git-send-email-brentadam@smarttech.com>
On Mon, 28 Sep 2015, Brent Adam wrote:
> Fixed the following checkpatch.pl warnings:
> WARNING: line over 80 characters: line 163
> WARNING: Missing a blank line after declarations: line 359
> WARNING: Missing a blank line after declarations: line 572
> WARNING: Missing a blank line after declarations: line 708
> WARNING: Missing a blank line after declarations: line 926
> WARNING: Possible unnecessary 'out of memory' message: line 1034
> WARNING: Possible unnecessary 'out of memory' message: line 1048
> WARNING: line over 80 characters: line 1390
For files which are already in tree I'd be taking such fixes only as a
side-change if refactoring the code anyway in a substantial way. Otherwise
I consider the ones below too minor to justify cluttering of git blame.
Thanks,
--
Jiri Kosina
SUSE Labs
next prev parent reply other threads:[~2015-09-29 12:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-28 20:03 Brent Adam
2015-09-29 12:59 ` Jiri Kosina [this message]
2015-09-29 14:13 ` Brent Adam
2015-09-30 7:55 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.00.1509291457360.30132@pobox.suse.cz \
--to=jikos@kernel.org \
--cc=brentadam@smarttech.com \
--cc=brentadamdev@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®