From: Brent Adam <BrentAdam@smarttech.com>
To: Jiri Kosina <jikos@kernel.org>
Cc: "linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] HID: hid-multitouch.c: fix formatting warnings
Date: Tue, 29 Sep 2015 14:13:51 +0000 [thread overview]
Message-ID: <C29E0AF0-087D-418B-B1FD-87A7392BF3C8@smarttech.com> (raw)
In-Reply-To: <alpine.LNX.2.00.1509291457360.30132@pobox.suse.cz>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 1180 bytes --]
On 9/29/15, 6:59 AM, "Jiri Kosina" <jikos@kernel.org> wrote:
>On Mon, 28 Sep 2015, Brent Adam wrote:
>
>> Fixed the following checkpatch.pl warnings:
>> WARNING: line over 80 characters: line 163
>> WARNING: Missing a blank line after declarations: line 359
>> WARNING: Missing a blank line after declarations: line 572
>> WARNING: Missing a blank line after declarations: line 708
>> WARNING: Missing a blank line after declarations: line 926
>> WARNING: Possible unnecessary 'out of memory' message: line 1034
>> WARNING: Possible unnecessary 'out of memory' message: line 1048
>> WARNING: line over 80 characters: line 1390
>
>For files which are already in tree I'd be taking such fixes only as a
>side-change if refactoring the code anyway in a substantial way. Otherwise
>I consider the ones below too minor to justify cluttering of git blame.
Ok, although Greg Kroah-Hartman inspires you in his video to submit patches
to make the code checkpatch clean. https://www.youtube.com/watch?v=LLBrBBImJt4
-Brent
ÿôèº{.nÇ+·®+%Ëÿ±éݶ\x17¥wÿº{.nÇ+·¥{±þG«éÿ{ayº\x1dÊÚë,j\a¢f£¢·hïêÿêçz_è®\x03(éÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?¨èÚ&£ø§~á¶iOæ¬z·vØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?I¥
next prev parent reply other threads:[~2015-09-29 14:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-28 20:03 Brent Adam
2015-09-29 12:59 ` Jiri Kosina
2015-09-29 14:13 ` Brent Adam [this message]
2015-09-30 7:55 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C29E0AF0-087D-418B-B1FD-87A7392BF3C8@smarttech.com \
--to=brentadam@smarttech.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®