From: Jiri Kosina <jikos@kernel.org>
To: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] floppy: make local variable non-static
Date: Tue, 8 Dec 2015 15:16:05 +0100 (CET) [thread overview]
Message-ID: <alpine.LNX.2.00.1512081515330.9922@cbobk.fhfr.pm> (raw)
In-Reply-To: <1448981641-17485-1-git-send-email-linux@rasmusvillemoes.dk>
On Tue, 1 Dec 2015, Rasmus Villemoes wrote:
> There's no reason for temparea to be static, since it's only used for
> temporary sprintf output. It's not immediately obvious that the output
> will always fit (in the worst case, the output including '\0' is
> exactly 32 bytes), so save a future reader from worrying about that.
>
> Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Applied, thanks.
(I have applied this to trivial.git, as was too lazy to revive floppy tree
just for this :) ).
--
Jiri Kosina
SUSE Labs
prev parent reply other threads:[~2015-12-08 14:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-01 14:54 Rasmus Villemoes
2015-12-08 14:16 ` Jiri Kosina [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.00.1512081515330.9922@cbobk.fhfr.pm \
--to=jikos@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®