From: Jiri Kosina <jikos@kernel.org>
To: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: Lauri Kasanen <cand@gmx.com>,
linux-input@vger.kernel.org, Max Fedotov <thesourcehim@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] HID: sony: do not bail out when the sixaxis refuses the output report
Date: Mon, 18 Jan 2016 23:11:07 +0100 (CET) [thread overview]
Message-ID: <alpine.LNX.2.00.1601182310490.21446@cbobk.fhfr.pm> (raw)
In-Reply-To: <1452272329-8744-1-git-send-email-benjamin.tissoires@redhat.com>
On Fri, 8 Jan 2016, Benjamin Tissoires wrote:
> When setting the operational mode, some third party (Speedlink Strike-FX)
> gamepads refuse the output report. Failing here means we refuse to
> initialize the gamepad while this should be harmless.
>
> The weird part is that the initial commit that added this: a7de9b8
> ("HID: sony: Enable Gasia third-party PS3 controllers") mentions this
> very same controller as one requiring this output report.
> Anyway, it's broken for one user at least, so let's change it.
> We will report an error, but at least the controller should work.
>
> And no, these devices present themselves as legacy Sony controllers
> (VID:PID of 054C:0268, as in the official ones) so there are no ways
> of discriminating them from the official ones.
>
> https://bugzilla.redhat.com/show_bug.cgi?id=1255325
>
> Reported-and-tested-by: Max Fedotov <thesourcehim@gmail.com>
> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Applied, thanks.
--
Jiri Kosina
SUSE Labs
prev parent reply other threads:[~2016-01-18 22:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-08 16:58 Benjamin Tissoires
2016-01-18 22:11 ` Jiri Kosina [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.00.1601182310490.21446@cbobk.fhfr.pm \
--to=jikos@kernel.org \
--cc=benjamin.tissoires@redhat.com \
--cc=cand@gmx.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thesourcehim@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®